Skip to content

/ accessibilityjs

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for `el.hasAttribute` before invoking #22

Merged
merged 1 commit into from May 11, 2018
Merged

Check for `el.hasAttribute` before invoking #22

merged 1 commit into from May 11, 2018

Conversation

@mislav
Copy link
Member

@mislav mislav commented May 8, 2018

This is called on nodes while traversing up the DOM, and there is no guarantee that a node is an Element node and that it will implement the hasAttribute function.
@mislav
Check for `el.hasAttribute` before invoking
Loading status checks…
bfd016b 
This is called on nodes while traversing up the DOM, and there is no
guarantee that a node is an Element node and that it will implement the
`hasAttribute` function.
@mislav mislav requested a review from muan May 9, 2018
@muan
muan approved these changes May 9, 2018
View changes
@mislav mislav merged commit 1b0731d into master May 11, 2018
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mislav mislav deleted the check-hasattribute branch May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muan muan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@mislav @muan
You can’t perform that action at this time.