Skip to content

THRIFT-5265 add the zlib transport to c_glib #2216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zeshuai007 wants to merge 1 commit into from
Closed

THRIFT-5265 add the zlib transport to c_glib #2216

zeshuai007 wants to merge 1 commit into from

Conversation

@zeshuai007
Copy link
Member

@zeshuai007 zeshuai007 commented Aug 13, 2020

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

@zeshuai007 zeshuai007 changed the title add the zlib transport to c_glib THRIFT5265 add the zlib transport to c_glib Aug 13, 2020
@zeshuai007 zeshuai007 changed the title THRIFT5265 add the zlib transport to c_glib THRIFT-5265 add the zlib transport to c_glib Aug 13, 2020
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 12, 2020
@stale
Copy link

stale bot commented Oct 16, 2020

This issue is no longer stale. Thank you for your contributions.

@stale stale bot removed the wontfix label Oct 16, 2020
@Jens-G
Copy link
Member

Jens-G commented Nov 19, 2020

Hi,
(1) whats the status of this?
(2) who could be possibly revieweing this? Its not really a smal change ...
(3) crosstested against some other impl, like c++?

@zeshuai007
Copy link
Member Author

zeshuai007 commented Nov 20, 2020

@Jens-G I will add crosstested against other impl soon.

@zeshuai007 zeshuai007 marked this pull request as draft November 20, 2020 09:15
@zeshuai007 zeshuai007 marked this pull request as ready for review November 30, 2020 06:26
@Jens-G
Copy link
Member

Jens-G commented Dec 9, 2020

Great!

@Jens-G
Copy link
Member

Jens-G commented Feb 4, 2021

Ping

@Jens-G
Copy link
Member

Jens-G commented Mar 31, 2021

@zeshuai007 merge?

@Jens-G Jens-G closed this in 037753e Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zeshuai007 @Jens-G