[redis] add 1 overload to SET command

[1pete]

adding support to redis SET command when sending arguments in this format

client.set('key', 'value', 'NX', 'EX', 1000, cb);

fixes #39051

[typescript-bot]

@1pete Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

• redis on npm, on unpkg

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

Status

• ✅ No merge conflicts
• ✅ Continuous integration tests have passed
• ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

---

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 48732,
  "author": "1pete",
  "owners": [
    "soywiz",
    "CodeAnimal",
    "MugeSo",
    "UppaJung",
    "Rokt33r",
    "43081j",
    "barnski",
    "1pete",
    "blablapolicja",
    "ferrantejake",
    "OpesanyaAdebayo",
    "nwtgck",
    "tdebarochez",
    "dwrss"
  ],
  "dangerLevel": "ScopedAndTested",
  "headCommitAbbrOid": "b17ead2",
  "headCommitOid": "b17ead2a0af35f335e92caee09dd95ecafcd40f9",
  "mergeIsRequested": true,
  "stalenessInDays": 0,
  "lastPushDate": "2020-10-13T03:18:10.000Z",
  "lastCommentDate": "2020-10-13T14:44:28.000Z",
  "maintainerBlessed": false,
  "reviewLink": "https://github.com/DefinitelyTyped/DefinitelyTyped/pull/48732/files",
  "hasMergeConflict": false,
  "authorIsOwner": true,
  "isFirstContribution": false,
  "popularityLevel": "Popular",
  "newPackages": [],
  "packages": [
    "redis"
  ],
  "files": [
    {
      "path": "types/redis/index.d.ts",
      "kind": "definition",
      "package": "redis"
    },
    {
      "path": "types/redis/redis-tests.ts",
      "kind": "test",
      "package": "redis"
    }
  ],
  "hasDismissedReview": false,
  "ciResult": "pass",
  "lastReviewDate": "2020-10-13T12:20:36.000Z",
  "reviewersWithStaleReviews": [],
  "approvalFlags": 2,
  "isChangesRequested": false
}

[typescript-bot]

🔔 @soywiz @CodeAnimal @MugeSo @UppaJung @Rokt33r @43081j @barnski @blablapolicja @ferrantejake @OpesanyaAdebayo @nwtgck @tdebarochez @dwrss — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

[danger-public]

Inspecting the JavaScript source for this package found some properties that are not in the .d.ts files.
The check for missing properties isn't always right, so take this list as advice, not a requirement.

redis (unpkg)

was missing the following properties:

1. debugMode
2. addCommand
3. add_command

Generated by 🚫 dangerJS against b17ead2

[typescript-bot]

👋 Hi there! I’ve run some quick measurements against master and your PR. These metrics should help the humans reviewing this PR gauge whether it might negatively affect compile times or editor responsiveness for users who install these typings.

Let’s review the numbers, shall we?

Comparison details 📊

	master	#48732	diff
Batch compilation
Memory usage (MiB)	76.0	70.8	-6.8%
Type count	9670	9680	0%
Assignability cache size	1694	1694	0%
Language service
Samples taken	380	395	+4%
Identifiers in tests	380	395	+4%
getCompletionsAtPosition
Mean duration (ms)	416.1	398.9	-4.1%
Mean CV	8.7%	9.0%
Worst duration (ms)	519.1	495.5	-4.5%
Worst identifier	hmset	ZINCRBY
getQuickInfoAtPosition
Mean duration (ms)	403.1	390.4	-3.1%
Mean CV	8.5%	9.3%	+9.4%
Worst duration (ms)	495.9	479.4	-3.3%
Worst identifier	okCallback	str

It looks like nothing changed too much. I won’t post performance data again unless it gets worse.

[typescript-bot]

@1pete Everything looks good here. Great job! I am ready to merge this PR on your behalf.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@soywiz, @CodeAnimal, @MugeSo, @UppaJung, @Rokt33r, @43081j, @barnski, @blablapolicja, @ferrantejake, @OpesanyaAdebayo, @nwtgck, @tdebarochez, @dwrss: you can do this too.)

[1pete]

Ready to merge

[typescript-bot]

I just published @types/redis@2.8.28 to npm.