Skip to content

/ substrate

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faulty BlockWeight on Runtime Upgrades #7427

Open
apopiak opened this issue Oct 26, 2020 · 0 comments
Open

Faulty BlockWeight on Runtime Upgrades #7427

apopiak opened this issue Oct 26, 2020 · 0 comments
Labels
I2-bug 🐜
Projects
Benchmarking and Weights

Comments

@apopiak
Copy link
Contributor

@apopiak apopiak commented Oct 26, 2020

We call register_extra_weight_unchecked (which mutates frame_system::BlockWeight) after the runtime upgrades, but we call BlockWeight::kill() in frame_system::initialize which happens after.
This will lead to faulty block weights for blocks that include runtime upgrades.
@apopiak apopiak mentioned this issue Oct 26, 2020
Draft
0 of 13 tasks complete
@apopiak apopiak added the I2-bug 🐜 label Oct 27, 2020
@apopiak apopiak added this to To do in Benchmarking and Weights via automation Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
I2-bug 🐜
Projects
Benchmarking and Weights
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
@apopiak
You can’t perform that action at this time.