Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Cancel button when editing a user #22608

Open
philipreimer opened this issue Sep 5, 2020 · 6 comments
Open

Add a Cancel button when editing a user #22608

philipreimer opened this issue Sep 5, 2020 · 6 comments

Comments

@philipreimer
Copy link

@philipreimer philipreimer commented Sep 5, 2020

How to use GitHub

  • Please use the 👍 reaction to show that you are interested into the same feature.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
There is no obvious intuitive way to cancel editing a user. This is confusing for first time admins.

Steps to reproduce

  1. Login to NC as an Admin
  2. Create a new user, setting a username and display name
  3. Edit the user
  4. Change the user's display name
  5. Realise that you did not actually want to change the user's display name

Now there is only the "OK" button with the check mark icon to submit your changes.
But there is no "Cancel" button to neglect your changes and go back to the original display name.

Describe the solution you'd like
Add a second button "Cancel" next to the "OK" button. Clicking the "Cancel" button should ignore (and maybe revert) any changes you have made to the user's properties and return back to displaying the user's original properties.

Describe alternatives you've considered
The only way I have found to effectively cancel editing a user was by reloading the entire page (F5).
However, that is not immediately obvious to newcomers.

Additional context

@jospoortvliet

This comment was marked as resolved.

@ayushkumar121
Copy link

@ayushkumar121 ayushkumar121 commented Sep 17, 2020

Hey can i take this 🤩? i'm new to contributions any help would be great

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 17, 2020

@ayushkumar121 of course! go for it!!
Feel free to join the dev channel here: https://cloud.nextcloud.com/call/xs25tz5y

Please also read our contribution page: https://nextcloud.com/contribute

@ayushkumar121
Copy link

@ayushkumar121 ayushkumar121 commented Sep 17, 2020

ok, Thanks

@sarahyaepark
Copy link

@sarahyaepark sarahyaepark commented Sep 24, 2020

Hi, @ayushkumar121! Are you still working on this? I'm also interested. :-)

@ayushkumar121
Copy link

@ayushkumar121 ayushkumar121 commented Sep 24, 2020

@sarahyaepark you go on ahead, i'm still facing problems in setting up the dev environment 😪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.