Skip to content

/ octodns

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: Bypass HTTP exception when adding non existing zones to powerdns #438

Open
wants to merge 2 commits into
base: master
from
Open

Bug fix: Bypass HTTP exception when adding non existing zones to powerdns #438

wants to merge 2 commits into from

Conversation

@aashifb
Copy link

aashifb commented Dec 18, 2019

This is in reference to issue #437
@aashifb aashifb force-pushed the aashifb:master branch 4 times, most recently from c8d711d to fb6518b Dec 18, 2019
@ross
ross approved these changes Jan 6, 2020
View changes
Copy link
Contributor

ross left a comment

👍. Will give you a chance to look at the minor suggestion and decide if you want to go that route or not before merging.
octodns/provider/powerdns.py Outdated Show resolved Hide resolved
@ross
Copy link
Contributor

ross commented Jan 6, 2020

Actually looks like the tests are failing. That'll need addressed first.
@ross ross mentioned this pull request Jan 6, 2020
Open
@aashifb
Copy link
Author

aashifb commented Jan 9, 2020

Actually looks like the tests are failing. That'll need addressed first.
@aashifb aashifb closed this Jan 9, 2020
@aashifb aashifb reopened this Jan 9, 2020
@aashifb
Copy link
Author

aashifb commented Jan 9, 2020

Thanks @ross. I'll look at the tests.
@aashifb aashifb force-pushed the aashifb:master branch from fb6518b to fabc500 Jan 9, 2020
@aashifb
Bug fix: Bypass exception when adding non existing zones to powerdns
Loading status checks…
a9e7dde
@aashifb aashifb force-pushed the aashifb:master branch from fabc500 to a9e7dde Jan 9, 2020
@ross
Merge branch 'master' into master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
82f247b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ross ross

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@aashifb @ross
You can’t perform that action at this time.