Skip to content

/ realworld

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Masonite #304

Open
vaibhavmule opened this issue Dec 4, 2018 · 9 comments · May be fixed by #379
Open

Masonite #304

vaibhavmule opened this issue Dec 4, 2018 · 9 comments · May be fixed by #379
Labels
backend wip

Comments

@vaibhavmule
Copy link

@vaibhavmule vaibhavmule commented Dec 4, 2018 •
edited

Hey,

I will be implementing the backend with Masonite. Masonite is the Modern And Developer Centric Python Web Framework.

Repo: https://github.com/vaibhavmule/masonite-realworld-example-app
@vaibhavmule vaibhavmule mentioned this issue Dec 4, 2018
Closed
5 of 6 tasks complete
@vaibhavmule
Copy link
Author

@vaibhavmule vaibhavmule commented Jan 18, 2019

@Cameron-C-Chapman just want to clarify for labels that it will be backend implementation not frontend.
@Cameron-C-Chapman Cameron-C-Chapman added backend and removed frontend labels Jan 18, 2019
@Cameron-C-Chapman
Copy link
Member

@Cameron-C-Chapman Cameron-C-Chapman commented Jan 18, 2019

@vaibhavmule I fixed that. Thanks!
@vaibhavmule vaibhavmule mentioned this issue Jan 24, 2019
Closed
2 of 2 tasks complete
vaibhavmule added a commit to vaibhavmule/realworld that referenced this issue Jun 24, 2019
@vaibhavmule
add masonite
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
73a5fef 
fixes gothinkster#304
@vaibhavmule vaibhavmule linked a pull request that will close this issue Jun 24, 2019
Open
@vaibhavmule
Copy link
Author

@vaibhavmule vaibhavmule commented Jun 24, 2019

@Cameron-C-Chapman I have worked on repo and ready and passed all the tests.
@vaibhavmule vaibhavmule changed the title Masonite Framework Masonite Jun 24, 2019
@anishkny
Copy link
Member

@anishkny anishkny commented Jun 24, 2019

@vaibhavmule could you add CI (Travis/Circle/Azure)?
@vaibhavmule
Copy link
Author

@vaibhavmule vaibhavmule commented Jun 25, 2019 •
edited

@anishkny Yes just updated the travis.yml.
@vaibhavmule
Copy link
Author

@vaibhavmule vaibhavmule commented Jul 28, 2019

@anishkny @Cameron-C-Chapman Just wanted to know, what can be done approved?
@anishkny
Copy link
Member

@anishkny anishkny commented Jul 28, 2019

@vaibhavmule this looks great! Could you run API tests against your backend to ensure it is compliant? preferably in Travis CI

https://github.com/gothinkster/realworld/tree/master/api
@vaibhavmule
Copy link
Author

@vaibhavmule vaibhavmule commented Jul 28, 2019 •
edited

@anishkny
Yeah, I could do that. Is there any example repo as I can have look. Thanks.
@anishkny
Copy link
Member

@anishkny anishkny commented Aug 2, 2019

Basically you would need to spin up your backend, and then execute:

APIURL=http://localhost:8000/ run-api-tests.sh

(assuming port 8000)

See: https://github.com/gothinkster/realworld/blob/master/api/run-api-tests.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend wip
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

add masonite
3 participants
@anishkny @Cameron-C-Chapman @vaibhavmule
You can’t perform that action at this time.