Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd SPM support #359
Add SPM support #359
Conversation
|
|
pomozoff
force-pushed the
pomozoff:master
branch
7 times, most recently
from
ee53467
to
8d18379
|
Hi @sbarow , could you please take a look at this PR? |
|
@Leland-Takamine Can we land this to get Travis working again? |
|
Welp gotta get their attention somehow https://twitter.com/elliomax/status/1250814239846961153 |
| name: "RIBsTests", | ||
| dependencies: ["RIBs"], | ||
| path: "ios/RIBsTests", | ||
| exclude: ["ComponentizedBuilderTests.swift", "MultiStageComponentizedBuilderTests.swift"] |
kovpas
May 2, 2020
Contributor
Why did you exclude these two?
Why did you exclude these two?
pomozoff
May 2, 2020
Author
Contributor
Unfortunately, I don't remember. I've added them back and seems like everything builds well.
Unfortunately, I don't remember. I've added them back and seems like everything builds well.
|
Hey @pomozoff, thanks for contribution and sorry for the delay! I've added a comment, please have a look. |
|
Thanks @pomozoff. Could you please revert the changes to the templates though? Let's keep this one out of this PR. |
| - IOS_SDK=iphonesimulator12.2 | ||
| - IOS_VER=12.2 # Tests must run at the same OS version as $IOS_SDK | ||
| - IOS_SDK=iphonesimulator13.2 | ||
| - IOS_VER=13.2 # Tests must run at the same OS version as $IOS_SDK |
kovpas
May 3, 2020
Contributor
This one should be 13.2.2 in order for build to pass, I believe
This one should be 13.2.2 in order for build to pass, I believe
|
Thanks @pomozoff. Mind also reverting the changes to the templates? |
|
@kovpas, oops, haven't seen my local changes are in the master, reverted them back |
| - LC_CTYPE=en_US.UTF-8 | ||
| - LANG=en_US.UTF-8 | ||
| - IOS_SDK=iphonesimulator12.2 | ||
| - IOS_VER=12.2 # Tests must run at the same OS version as $IOS_SDK | ||
| # - IOS_VER=$( xcrun --sdk iphonesimulator --show-sdk-version ) # Tests must run at the same OS version as $IOS_SDK |
kovpas
May 4, 2020
Contributor
Please remove
Please remove
|
Thanks! Please fix one little nit and I'll merge this one in. |
Description:
Add SPM support
Related issue(s): #358