Add extension methods for adding services with custom dependencies #101

luca-esse · 2019-10-05T12:40:58Z

This PR adds extension methods for defining cutom dependencies on specific services.

I came up with this idea because a lot of people didn't like the approach MS have taken with the generic ILogger<T> and the named IOptions<TOptions> (If you have multiple IOptions<TOptions> of the same type you have to retrive the correct instance by name inside of the costructor of the service where they are being injected)

Common usages:

Inject the desired service when multiple implementations are registered:

var services = new ServiceCollection();

services.AddSingleton<SomeService1>();
services.AddSingleton<SomeService2>();

services.AddWithDependencies(() =>
{
    services.AddSingleton<MainService>();
}, typeof(SomeService2));

public interface ISomeService { }

public class SomeService1 : ISomeService { }
public class SomeService2 : ISomeService { }

public class MainService 
{
    public MainService(ISomeService someService)
    {
        // someService.GetType() == typeof(SomeService2)
    }
}

Avoid injecting the generic ILogger<T>:

var services = new ServiceCollection();

services.AddLogging();

services.AddWithDependencies(() =>
{
    services.AddSingleton<SomeService>();
    services.AddSingleton<SomeOtherService>();
},
(serviceProvider, injectionContext) => new [] {
     serviceProvider.GetRequiredService<ILoggerFactory>().CreateLogger(injectionContext.CreatingServiceType)
});

public class SomeService
{
    public SomeService(ILogger logger) 
    { 
        // logger.GetType() == typeof(Logger<SomeService>)
    }
}

public class SomeOtherService
{
    public SomeOtherService(ILogger logger) 
    { 
        // logger.GetType() == typeof(Logger<SomeOtherService>)
    }
}

Add extension methods for adding services with custom dependencies

Verified

This commit was signed with a verified signature.

luca-esse

GPG key ID: 228CE147C5E944DD Learn about signing commits

Loading status checks…

17e4767

khellang / Scrutor

Add extension methods for adding services with custom dependencies #101

Add extension methods for adding services with custom dependencies #101

luca-esse commented Oct 5, 2019 •

edited

khellang / Scrutor

Join GitHub today

Add extension methods for adding services with custom dependencies #101

Add extension methods for adding services with custom dependencies #101

Conversation

luca-esse commented Oct 5, 2019 • edited

Common usages:

Essential cookies

Always active

Analytics cookies

luca-esse commented Oct 5, 2019 •

edited