Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PyTorch and/or TensorFlow sequence classification architectures for causal language models #7623

Open
LysandreJik opened this issue Oct 6, 2020 · 13 comments

Comments

@LysandreJik
Copy link
Member

@LysandreJik LysandreJik commented Oct 6, 2020

🚀 Feature request

The architecture GPT2ForSequenceClassification was added in #7501 in PyTorch. It would be great to have it in TensorFlow (cf. issues #7622), but it would also be great to have it for other causal models: OpenAI GPT, CTRL, TransfoXL

Currently working on OpenAI GPT: @fmcurti (done)

Below is a list of items to follow to make sure the integration of such an architecture is complete:

  • Implement XXXForSequenceClassification in modeling_xxx.py or TFXXXForSequenceClassification in `modeling_tf_xxx.py
  • Test that architecture in tests/test_modeling_xxx.py or tests/test_modeling_tf_xxx.py
  • Add that architecture to __init__.py and docs/source/model_doc/xxx.rst.

Taking a look at the code changes in #7501 would be a good start.

A very good first issue to get acquainted with the library and its architectures!

@fmcurti fmcurti mentioned this issue Oct 7, 2020
0 of 1 task complete
@pasDamola
Copy link

@pasDamola pasDamola commented Oct 8, 2020

Hi @LysandreJik is this issue still open? I'll like to pick it up

@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Oct 9, 2020

I believe @fmcurti is working on the OpenAI GPT implementation, but both CTRL and TransfoXL are still open! Would love a PR!

@pasDamola
Copy link

@pasDamola pasDamola commented Oct 9, 2020

@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Oct 9, 2020

Sure, have you taken a look at the CONTRIBUTING.md document? What issues have you been having?

@pasDamola
Copy link

@pasDamola pasDamola commented Oct 9, 2020

Yes I have.
When I run pip install -e ".[dev]", I always encounter this error. I'm also running it in anaconda environment

Screenshot (406)

`

@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Oct 9, 2020

I believe the repo cannot be installed from conda as of now, can you use a pip virtual environment?

@pasDamola
Copy link

@pasDamola pasDamola commented Oct 9, 2020

Alright, I'll try that now

@pasDamola
Copy link

@pasDamola pasDamola commented Oct 9, 2020

Still having the same error I had while in conda. I'm trying to install tensorflow locally and retry this again

@pasDamola
Copy link

@pasDamola pasDamola commented Oct 9, 2020

Hi @LysandreJik , I'm still having the same errors running on a pip virtual environment

@fmcurti fmcurti mentioned this issue Oct 9, 2020
4 of 5 tasks complete
@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Oct 9, 2020

Do you manage to install TensorFlow in your pip environment?

@pasDamola
Copy link

@pasDamola pasDamola commented Oct 9, 2020

Hi @LysandreJik not yet. I get a similar error. I'm trying to look for solutions on the internet

Screenshot (407)

@amritrau
Copy link

@amritrau amritrau commented Oct 25, 2020

Hi @LysandreJik – has anyone picked up the CTRL or TransfoXL architectures yet? I'd love to take a crack at one of them if available. Thank you!

@LysandreJik
Copy link
Member Author

@LysandreJik LysandreJik commented Oct 26, 2020

No, feel free to take a crack at it! Let me know and I'll put you in the issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants
You can’t perform that action at this time.