Skip to content

/ devhub

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Linux fixes #79

Open
brunolemos opened this issue Dec 30, 2018 · 4 comments
Open

[Desktop] Linux fixes #79

brunolemos opened this issue Dec 30, 2018 · 4 comments
Labels
bug desktop help wanted
Projects
DevHub

Comments

@brunolemos
Copy link
Member

@brunolemos brunolemos commented Dec 30, 2018 •
edited

Fixed on v0.42.0

  • Fix super lag and machine freezing (caused by setSkipTaskBar)
  • Fix oauth flow

Fixed on v0.43.0

  • Fix logo not showing on dock
  • Exit full screen with Esc
  • Disable super buggy "Lock on center" feature or fix it if possible

Pending fixes

  • [IMPORTANT] Fix devhub:// url scheme not working (related: #95)
  • Fix menubar mode

    Currently not possible to do it the "right way" because tray.getBounds() returns all values as zero on linux (electron/electron#15003).
    electron-traywindow-positioner has a workaround using the cursor position (I don't want to add this dependency, but maybe do some similar workaround).

  • Fix logo not showing on .AppImage file
  • Fix pixelated logo on dock, make it high quality instead
@brunolemos brunolemos mentioned this issue Dec 30, 2018
Closed
@brunolemos brunolemos added this to Next in DevHub Dec 30, 2018
@brunolemos brunolemos closed this in 73f3132 Jan 4, 2019
DevHub automation moved this from Next to Done Jan 4, 2019
@brunolemos brunolemos reopened this Jan 4, 2019
DevHub automation moved this from Done to To do Jan 4, 2019
@brunolemos brunolemos added this to the v0.42.0 milestone Jan 4, 2019
@brunolemos brunolemos changed the title [Desktop] Fix linux app [Desktop] Linux fixes Jan 4, 2019
@brunolemos brunolemos modified the milestones: v0.42.0, v0.43.0 Jan 6, 2019
brunolemos added a commit that referenced this issue Jan 7, 2019
@brunolemos
[Desktop] Disable "Lock on center" on Linux
Verified
This commit was signed with a verified signature.
brunolemos Bruno Lemos
GPG key ID: 56ECEA49AAC4CE9F Learn about signing commits
aa503a1 
Too buggy on resize

 #79
brunolemos added a commit that referenced this issue Jan 7, 2019
@brunolemos
[Desktop] Show pixelated icon on Linux
Verified
This commit was signed with a verified signature.
brunolemos Bruno Lemos
GPG key ID: 56ECEA49AAC4CE9F Learn about signing commits
14a99f1 
Better than nothing, but not good enough

 #79
brunolemos added a commit that referenced this issue Jan 7, 2019
@brunolemos
[Desktop] Exit full screen with
Verified
This commit was signed with a verified signature.
brunolemos Bruno Lemos
GPG key ID: 56ECEA49AAC4CE9F Learn about signing commits
1d03d76 
 #79
@brunolemos brunolemos removed this from the v0.43.0 milestone Jan 12, 2019
@brunolemos brunolemos mentioned this issue Jan 12, 2019
Open
@LynnHo
Copy link

@LynnHo LynnHo commented Mar 13, 2019

@brunolemos The desktop software turns the login to the browser but nothing happens in the software after I finish login. Does anybody have the same situation?
@mukeshmandiwal
Copy link

@mukeshmandiwal mukeshmandiwal commented Mar 13, 2019

Same here
@brunolemos brunolemos mentioned this issue May 7, 2019
Merged
7 of 22 tasks complete
@x0s3
Copy link

@x0s3 x0s3 commented Jul 9, 2019

I have not been able to get a workaround due a problems with my virtual machines 😞 but it sounds to me that this way is the only one to handle deep-linking with linux, the trick may be in the .desktop file.

Here I leave a possible point to dig in 👀: https://github.com/mattermost/desktop/tree/master/resources/linux
@brunolemos
Copy link
Member Author

@brunolemos brunolemos commented Jul 9, 2019

I opened electron-userland/electron-builder#4035, let’s see.
brunolemos added a commit that referenced this issue Jul 9, 2019
@brunolemos
[Desktop] Fix linux oauth flow
Verified
This commit was signed with a verified signature.
brunolemos Bruno Lemos
GPG key ID: 56ECEA49AAC4CE9F Learn about signing commits
440c5a0 
#79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug desktop help wanted
Projects
DevHub
  
To do
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@brunolemos @mukeshmandiwal @LynnHo @x0s3
You can’t perform that action at this time.