Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup bash & zsh autocomplete as part of brew install #264

Open
bfarayev opened this issue Nov 13, 2019 · 2 comments
Open

Setup bash & zsh autocomplete as part of brew install #264

bfarayev opened this issue Nov 13, 2019 · 2 comments

Comments

@bfarayev
Copy link
Contributor

@bfarayev bfarayev commented Nov 13, 2019

Now that we have bash & zsh autocomplete scripts in this repo, we can install them as part of installation with homebrew.

I've noticed that we have this formula already: https://github.com/go-task/homebrew-tap/blob/master/Formula/go-task.rb

Adding 2 lines to the formula, will do that for us:

    bash_completion.install "completion/bash/task.bash" => "task"
    zsh_completion.install "completion/zsh/_task" => "_task"

I was just testing this on my machine today. Happy to raise a PR for that if it's fine.

Thanks

@andreynering
Copy link
Contributor

@andreynering andreynering commented Nov 16, 2019

Hi @bfarayev,

Yeah, it'd be nice to have that. Contributions would be welcome. 🙂

We'd probably have to adapt our Goreleaser setup to also include these completion scripts on the .tar.gz files.

Also, we need to make sure that it won't break stuff for users that try install an older version (without the completion scripts in the tarball).

@andreynering
Copy link
Contributor

@andreynering andreynering commented Oct 12, 2020

Some additional instructions on how to do it was added by @zx8 here: #382 (comment)

Contributions with this are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.