Skip to content
#

hacklang

Star

Here are 89 public repositories matching this topic...

Language: All
Filter by language
All 89 Hack 60 Shell 13 C++ 4 JavaScript 2 PHP 2 C# 1 HTML 1 OCaml 1 TypeScript 1 Vim script 1
Sort: Best match
Sort options
Best match Most stars Fewest stars Most forks Fewest forks Recently updated Least recently updated

hhvm / hhast

Star
Open

Understand calculated width not matching sourceRef width

1
fredemmott
fredemmott commented Oct 23, 2020

I wanted to optimize Node::getWidth() by using the $this->sourceRef['width'] when available; this doesn't match:

diff --git a/src/nodes/Node.hack b/src/nodes/Node.hack
index 36135d86..0e7346f5 100644
--- a/src/nodes/Node.hack
+++ b/src/nodes/Node.hack
@@ -103,6 +103,15 @@ abstract class Node implements IMemoizeParam {
         $width += $node->getWidth();
       }
       $this->
Read more
good first issue
Find more good first issues →

Improve this page

Add a description, image, and links to the hacklang topic page so that developers can more easily learn about it.

Curate this topic

Add this topic to your repo

To associate your repository with the hacklang topic, visit your repo's landing page and select "manage topics."

Learn more

You can’t perform that action at this time.