Convert photorec to use RawDiskPartition #619
Conversation
Pull from upstream
Pull from upstream
Pull from upstream
Pull from upstream
Merge from upstream
|
As you mentioned elsewhere, the previous changes are showing up here, so it's a bit hard to review. I'm guessing you created this branch from the previous feature branch and not directly from master? Maybe you could try syncing your master branch, then creating a new branch from there and then cherry-picking the actual new commits? Maybe github is calculating the diffs based on the commits rather than the actual code diff here, and since those commits were squashed when merged into upstream master, it still thinks they are "new"? |
|
Sorry about that, rebased the branch. Should be good now. |
| # Add the output path to the evidence so we can automatically save it | ||
| # later. | ||
| output_evidence.local_path = output_file_path | ||
| output_evidence.local_path = ''.join((output_file_path, '.1')) |
There was a problem hiding this comment.
Photorec appends .1 to whatever output folder specified.
I guess this is to support multiple runs with an incrementing number on the output folder.
There was a problem hiding this comment.
Weird. Should we do a quick check to make sure this exists after the run then?
|
@aarontp I've moved the extraction of volume extents into the partition enumeration task and stored the values in the evidence item. I also changed the logic a little to support images that are taken at the volume level (i.e. no partition table). |
| # Add the output path to the evidence so we can automatically save it | ||
| # later. | ||
| output_evidence.local_path = output_file_path | ||
| output_evidence.local_path = ''.join((output_file_path, '.1')) |
There was a problem hiding this comment.
Weird. Should we do a quick check to make sure this exists after the run then?
|
Fixed |
2 participants
Issue #78