Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Storage documentation is incorrect #682
Comments
|
There is at least an implementation in "simple storage" but I am confused as to what the intended api should be. The implementation I linked to says that |
|
I can confirm that all of the |
|
Is this fixed? #854 |
|
I'm not sure from the comments: should we have delete methods? I'm needing them on MongoDB storage and i'm not sure if I should create a PR here in the project or should place it only inside my custom code. What do you think? |
|
The Jabber bot looks like it requires both 'delete' and 'all' to be implemented for storage methods. CoreBot already checks for the existence of 'get' and 'save', but not 'delete' and 'all'. Checks for 'delete' and 'all' could be added to the CoreBot (which might be a breaking change), placed in the Jabber bot, or the documentation updated to include either indicating that Jabber will only work with some storage mechanism implementations, or for the storage mechanisms indicating what methods that they should implement. It looks like the Mongo storage implements all four methods now, as does Redis (except that 'delete' is 'remove'), and Datastore and Firebase do not implement 'delete'. |
|
Looking at the other plugins (those listed here): CouchDB and Datastore support all four methods |
|
hey @fastbean-au are you a member of community.botkit.ai? you should join if not! |
In the storage section of the README it mentions that storage backends should implement
deletemethods.None of the available backends implement
deletenor can I find it in the internal implementation.The documentation needs to be updated presumably.