Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Go 1.15 and 1.14 in workflows/tests.yml #1605

Merged
merged 1 commit into from Aug 16, 2020
Merged

Conversation

@gmlewis
Copy link
Collaborator

@gmlewis gmlewis commented Aug 15, 2020

Since Go 1.15 has been released, and we want to test the two most recent major releases of Go on this repo, this PR bumps workflows/tests.yml to test the most recent (1.x) version of Go, and the next-most-recent (1.14.x) version.

@google-cla google-cla bot added the cla: yes label Aug 15, 2020
@codecov
Copy link

@codecov codecov bot commented Aug 15, 2020

Codecov Report

Merging #1605 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1605   +/-   ##
=======================================
  Coverage   68.04%   68.04%           
=======================================
  Files          97       97           
  Lines        8830     8830           
=======================================
  Hits         6008     6008           
  Misses       1908     1908           
  Partials      914      914           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d9ab32...a651c4c. Read the comment docs.

@gmlewis gmlewis requested a review from wesleimp Aug 15, 2020
@gmlewis
Copy link
Collaborator Author

@gmlewis gmlewis commented Aug 15, 2020

@nightlark - if you are available, please feel free to approve this PR. Thanks.

Copy link
Contributor

@nightlark nightlark left a comment

LGTM.

@gmlewis
Copy link
Collaborator Author

@gmlewis gmlewis commented Aug 16, 2020

Thank you, @nightlark !
Merging.

@gmlewis gmlewis merged commit 00ac78b into google:master Aug 16, 2020
7 checks passed
7 checks passed
test (1.x, ubuntu-latest)
Details
test (1.x, windows-latest)
Details
test (1.14.x, ubuntu-latest)
Details
test (1.14.x, windows-latest)
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 5d9ab32...a651c4c
Details
codecov/project 68.04% (+0.00%) compared to 5d9ab32
Details
@gmlewis gmlewis deleted the gmlewis:go1-15 branch Aug 16, 2020
n1lesh pushed a commit to n1lesh/go-github that referenced this pull request Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants