Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCode coverage improvements #1024
Merged
Conversation
|
@profnandaa I have some other little fixes, should i open a new PR or push to this one? |
|
Sure, can make it a separate PR.
-na
On Sat, May 25, 2019 at 2:08 PM Sarhan Aissi ***@***.***> wrote:
@profnandaa <https://github.com/profnandaa> I have some other little
fixes, should i open a new PR or push to this one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1024>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB7ZEOJAFII2XK2JNYFGH3PXEMZFANCNFSM4HK4FBGQ>
.
--
Sent from a tiny device while on the move.
|
|
LGTM |
|
@tux-tn -- sorry for my delay to reviewing this. Please fix the merge conflicts and we should land. |
|
@tux-tn thank you for taking time to look into this, my branch is now up to date with master |
|
@profnandaa can we add a tool like Coveralls or Codecov to handle coverage change in future PRs? |
|
Good idea, for sure. Please open an issue for this, I'll follow up
with @chriso
…On Tue, Jun 18, 2019 at 6:48 PM Sarhan Aissi ***@***.***> wrote:
@profnandaa <https://github.com/profnandaa> can we add a tool like
Coveralls or Codecov to handle coverage change in future PRs?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1024>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAB7ZEJ23XVQWD7VCSZBQS3P3D7TNANCNFSM4HK4FBGQ>
.
--
*Nandaa **Anthony*
*,*Software Craftsman & Mentor
*Twitter/Github: *@profnandaa <http://twitter.com/profnandaa>
*Blog: *www.nandaa.com <http://nandaa.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
tux-tn commentedMay 5, 2019
Hello,
This PR contains various changes:
\Sas chars for example)errorintestfunction add possibility to check for thrown error in validators, mainly used in working with non-existing locales.Not very confident about adding tooling/dependencies without prior discussions but I also added istanbul/nyc , it helped me to find and fix unhandled conditions and cases and may be very useful for validator.js PRs when linked with Codecov or Coverall.
Coverage before changes:
Coverage after changes: