Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd getting-started example for create-react-app (#920) #1003
Conversation
|
Hmm... I'm confused about the Travis error. When I run the tests in my CLI, I get this error message (which isn't terribly helpful): npm ERR! code ELIFECYCLE Have I made a mistake or omitted something necessary? (This is my first pull request here.) Thanks in advance. |
| "eject": "react-scripts eject" | ||
| }, | ||
| "eslintConfig": { | ||
| "extends": "react-app" |
Pessimistress
Jan 24, 2020
Collaborator
This is breaking CI. You need to either remove this or add eslint-config-react-app to the root devDependencies.
This is breaking CI. You need to either remove this or add eslint-config-react-app to the root devDependencies.
RobJacobson
Jan 28, 2020
Author
Thanks. I added the dev dependency.
Thanks. I added the dev dependency.
Pessimistress
Jan 29, 2020
Collaborator
You need to add it to the root package.json. CI does not install dependencies for each example.
You need to add it to the root package.json. CI does not install dependencies for each example.
|
I've made the requested changes. However, I'm still failing the Travis CI check. Can you provide any guidance? |
| @@ -0,0 +1,23 @@ | |||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | |||
Pessimistress
Jan 29, 2020
Collaborator
Do you need this file specifically for this example? Can this be rolled into the root .gitignore?
Do you need this file specifically for this example? Can this be rolled into the root .gitignore?
You need to add it to the root package.json. CI does not install dependencies for each example. |
|
I'm terribly sorry, but the Travis build failed again. I removed "eslint-config-react-app" from the example's config.json file and moved it to config.json in the root project. Could you please provide a further hint? (The Travis CI check seems like a "black box" to me.) |
CI runs If you don't really need the eslint setup for your example, then just remove it period. The repo has its own eslint configuration. |
|
Looks like you have committed some irrelevant files in |
|
Thank you. I've done the following:
Unfortunately, the Travis check is still failing. I'm feeling like an idiot. Could you please elaborate again on the problem? |
|
CI is failing for a different issue (lint error).
Have you run |
|
Thanks for your tip. I'm using VS Code with the ESLint extension. I'm getting the following error message at the top level of the project:
What am I doing wrong? Thanks for your patience with this issue. |
|
This issue was recently fixed, you may need to rebase master. |
Here's a first attempt at adding a minimal example using create-react-app. How does this look?