Skip to content

/ create-react-app

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v4] Bug: React 17, React is not defined after ejecting #9953

Open
alpeer opened this issue Oct 29, 2020 · 4 comments · May be fixed by #9858
Open

[v4] Bug: React 17, React is not defined after ejecting #9953

alpeer opened this issue Oct 29, 2020 · 4 comments · May be fixed by #9858
Labels
contributions: up for grabs! good first issue issue: bug issue: needs investigation

Comments

@alpeer
Copy link

@alpeer alpeer commented Oct 29, 2020

React version: 17.0.1

Steps To Reproduce

  1. npx create-react-app my-app
  2. cd my-app
  3. npm start (Works like a charm)
  4. npm run eject
  5. npm i
  6. npm start (ReferenceError: React is not defined)

Link to code example: https://codesandbox.io/s/ecstatic-wood-ou6px

The current behavior

I upgraded react to 17 and removed "import React"s from my project files (except index.js where react mounted). But I got "ReferenceError: React is not defined" in those files.
To investigate the issue behind this, I created a new react app, the new JSX transformation was working. But when I eject, it throws the same errors.
So;
Without react-scripts, new JSX transformation doesn't working.

The expected behavior

Components should render without declaring React (import React from "react") if React is in scope.
@kachkaev
Copy link

@kachkaev kachkaev commented Oct 29, 2020

I guess that this issue should be moved to https://github.com/facebook/create-react-app
@gaearon gaearon transferred this issue from facebook/react Oct 29, 2020
@gaearon gaearon changed the title Bug: React 17, React is not defined [v4] Bug: React 17, React is not defined Oct 29, 2020
@gaearon gaearon changed the title [v4] Bug: React 17, React is not defined [v4] Bug: React 17, React is not defined after ejecting Oct 29, 2020
@alpeer
Copy link
Author

@alpeer alpeer commented Oct 29, 2020

This is not an issue about create-react-app.
I don't use create-react-app in the project I had problem with jsx-transformation.
I have just mention to show you example and give more idea about issue.

Thanks for replying quickly.
Happy coding :)
@mordechaim
Copy link

@mordechaim mordechaim commented Oct 29, 2020

I'm having this exact issue even without ejecting. I followed the migration guide, ran react-codemod, deleted node_modules.

The compiler says the code compiled successfully but getting the red screen in the browser.
@ehsankhfr ehsankhfr linked a pull request that will close this issue Nov 1, 2020
Open
@n3tr
Copy link
Contributor

@n3tr n3tr commented Nov 1, 2020

@alpeer

Upgrade React 17 and remove import React statements won't work since React doesn't do any JSX transform, you need babel plugin for that (https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#manual-babel-setup).

the CRA ejection issue has been fixed in #9885 and needs to wait for the maintainer to publish a new version.

:)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions: up for grabs! good first issue issue: bug issue: needs investigation
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Simple Tasks fixes and Fix #9953
5 participants
@n3tr @kachkaev @gaearon @mordechaim @alpeer
You can’t perform that action at this time.