Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better attribution of PlotView (WinForms) #1468

Open
maettu-this opened this issue Feb 7, 2020 · 1 comment
Open

Better attribution of PlotView (WinForms) #1468

maettu-this opened this issue Feb 7, 2020 · 1 comment

Comments

@maettu-this
Copy link

@maettu-this maettu-this commented Feb 7, 2020

Improvement description related to the Text property

The Text property is of no use. Inheriting from UserControl instead of Control would fix this, i.e. hide it. Alternatively:

[Bindable(false)]
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
[EditorBrowsable(EditorBrowsableState.Never)]
public override string Text { get; set; }

Improvement description related to the *Cursor properties

The [OxyPlotCategory] properties *Cursor should have the [Description] and [DefaultValue] attributes. The first for the obvious reason, the latter for proper behaviour in the Visual Studio designer, e.g. no code generated in the form's .Designer.cs for properties still using default values.

@objorke
Copy link
Member

@objorke objorke commented Feb 8, 2020

Inherit from UserControl sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.