Conversation
litteredwitherrors
added
area:fast-components
docs:example
litteredwitherrors
requested review from
EisenbergEffect,
chrisdholt,
janechu and
nicholasrice
as code owners
EisenbergEffect
approved these changes
Oct 2, 2020
EisenbergEffect
changed the title
chrisdholt
approved these changes
Oct 2, 2020
Member
chrisdholt
left a comment
chrisdholt
left a comment
There was a problem hiding this comment.
This is a great addition @litteredwitherrors, thank you!
janechu
approved these changes
Oct 2, 2020
nicholasrice
reviewed
Oct 6, 2020
nicholasrice
reviewed
Oct 6, 2020
nicholasrice
reviewed
Oct 6, 2020
nicholasrice
reviewed
Oct 6, 2020
Contributor
|
@litteredwitherrors Let's get this merged 😄 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
warning:stale
litteredwitherrors
force-pushed
the
users/litteredwitherrors/improve-fast-components-contributing
branch
from
14edece to
24315ca
Compare
stale
bot
removed
the
warning:stale
awentzel
approved these changes
Feb 3, 2021
…onents-contributing
…onents-contributing
|
Code Climate has analyzed commit 63dd246 and detected 0 issues on this pull request. View more on Code Climate. |
awentzel
deleted the
users/litteredwitherrors/improve-fast-components-contributing
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more detailed instructions to the CONTRIBUTING.md file in the
fast-componentsweb-component package.Motivation & context
Issue type checklist
Is this a breaking change?
Adding or modifying component(s) in
@microsoft/fast-componentschecklistProcess & policy checklist