Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

safe_psql() method returns byte string #58

Open
gsmol opened this issue Oct 28, 2020 · 1 comment
Open

safe_psql() method returns byte string #58

gsmol opened this issue Oct 28, 2020 · 1 comment
Labels
bug

Comments

@gsmol
Copy link
Contributor

@gsmol gsmol commented Oct 28, 2020

Previously it was returning text, so now you have to manually decode it.

@gsmol gsmol added the bug label Oct 28, 2020
@arssher
Copy link
Contributor

@arssher arssher commented Oct 28, 2020

Well, I don't see Popen call being changed in the last two years neither previously existed decode(). At which commit/version you saw the previous behaviour?

At least pathman tests rely on bytes returned in several places, so should be new method (or argument) at this point anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.