Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
*: switch systemd & dropin Contents to Resource type #986
Conversation
|
Code itself isn't tested yet or final, wanted to get this up now to discuss the trade-off (no longer being able to validate unit & dropin contents during validation). |
Switching the Contents field to the Resource type allows additional flexibility when specifying unit contents.
| @@ -121,9 +121,23 @@ The Ignition configuration is a JSON document conforming to the following specif | |||
| * **_enabled_** (boolean): whether or not the service shall be enabled. When true, the service is enabled. When false, the service is disabled. When omitted, the service is unmodified. In order for this to have any effect, the unit must have an install section. | |||
| * **_mask_** (boolean): whether or not the service shall be masked. When true, the service is masked by symlinking it to `/dev/null`. | |||
| * **_contents_** (string): the contents of the unit. | |||
lucab
Jun 18, 2020
Member
s/string/object/ I think? Also, isn't this a major schema break?
s/string/object/ I think? Also, isn't this a major schema break?
bgilbert
Jun 18, 2020
Member
Whoops, yeah. This would require us to move to spec 4.0.0. Arguably that's okay -- the change is still translatable, so we can support both 3.x and 4.0 in the same code -- but we've avoided incompatible changes so far. But it also makes the original use case harder to implement in handwritten configs, since they'd need to convert to data URLs.
Whoops, yeah. This would require us to move to spec 4.0.0. Arguably that's okay -- the change is still translatable, so we can support both 3.x and 4.0 in the same code -- but we've avoided incompatible changes so far. But it also makes the original use case harder to implement in handwritten configs, since they'd need to convert to data URLs.
Switching the Contents field to the Resource type allows additional
flexibility when specifying unit contents.
This switch comes with the trade-off of no longer being able to
validate unit & dropin contents at validation time.
Closes #884