Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Add truncate functionality #162
Conversation
|
Great, you pretty much nailed it! There are some minor clean ups possible but that's fine. Are you running prettier? I should probably add a npm script for this. As for the checks yes that's a good point which I should explain a bit better. The checks are basically type-checking unit tests and makes sure we don't create any regressions with the types. With all the advanced typings going on it's very easy to make a mistake and get an It would be nice to get at least one check in to see the return type of the truncate query. I'm assuming this should be a number. The delete check is actually very similar (and simple), so you could try and copy that one. What do you think? It looks like the tests etc aren't running on this branch yet so I have some work to do. I'll get this sorted in the next couple of days. Good stuff! |
|
Hi @martijndeh |
I've added the truncate functionality as described here
Things that should be done after merge, which I'll do as well: