Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more DML tests for latin1 #291

Merged
merged 5 commits into from Nov 1, 2016
Merged

more DML tests for latin1 #291

merged 5 commits into from Nov 1, 2016

Conversation

@shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Oct 26, 2016

Storyline: #290

This PR adds update, delete to latin1 tests in an attempt to reproduce #290 , but the tests do not fail.

@shlomi-noach shlomi-noach merged commit 3435539 into master Nov 1, 2016
1 check passed
1 check passed
gh-ost-build-deploy-tarball Build #4576284 succeeded in 4s
Details
@shlomi-noach shlomi-noach deleted the more-charset-tests branch Nov 1, 2016
@MrMauricioLeite
Copy link

@MrMauricioLeite MrMauricioLeite commented Jul 19, 2017

This test do not cover TEXT columns. I'm having no trouble with VARCHAR columns but on TEXT columns I'm experiencing the same charset errors other were facing with varchar columns.

Does it make any sense?

@shlomi-noach
Copy link
Contributor Author

@shlomi-noach shlomi-noach commented Jul 20, 2017

I'll add tests for TEXT columns as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.