Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matrix_exp + matrix_exp.backward complex support #48363

Closed
wants to merge 7 commits into from
Closed

matrix_exp + matrix_exp.backward complex support #48363

wants to merge 7 commits into from

Conversation

nikitaved
Copy link
Collaborator

@nikitaved nikitaved commented Nov 21, 2020

As per title. Fixes #48299.

@nikitaved nikitaved added the module: complex label Nov 21, 2020
@codecov
Copy link

@codecov codecov bot commented Nov 21, 2020 •
edited

Codecov Report

Merging #48363 (20aefef) into master (4ed7f36) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           master   #48363    +/-   ##
========================================
  Coverage   80.94%   80.95%            
========================================
  Files        1854     1853     -1     
  Lines      199918   199805   -113     
========================================
- Hits       161831   161759    -72     
+ Misses      38087    38046    -41

@mruberry mruberry requested a review from albanD Nov 22, 2020
@mruberry mruberry added triaged complex_autograd labels Nov 22, 2020
@dr-ci
Copy link

@dr-ci dr-ci bot commented Nov 23, 2020 •
edited

💊 CI failures summary and remediations

As of commit bd5dedb (more details on the Dr. CI page):

✅ None of the CI failures appear to be your fault 💚

🚧 1 ongoing upstream failure:

These were probably caused by upstream breakages that are not fixed yet:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker or post in the (internal) Dr. CI Users group.

See how this bot performed.

This comment has been revised 4 times.

albanD
albanD reviewed Nov 30, 2020
View changes
Copy link
Contributor

@albanD albanD left a comment

Thanks for the PR!

Look good. Just minor comments.
Not sure why the bazel build failed but it looks unrelated right?

aten/src/ATen/native/LinearAlgebra.cpp Outdated Show resolved Hide resolved
test/test_torch.py Outdated Show resolved Hide resolved
@nikitaved
Copy link
Collaborator Author

@nikitaved nikitaved commented Nov 30, 2020

@albanD , thank you for the review! I have rebased the code to resolve the conflicts. The bazel issues are not related, indeed.

albanD
albanD approved these changes Nov 30, 2020
View changes
Copy link
Contributor

@albanD albanD left a comment

Thanks for the update!

facebook-github-bot
facebook-github-bot reviewed Nov 30, 2020
View changes
Copy link
Contributor

@facebook-github-bot facebook-github-bot left a comment

@albanD has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@nikitaved nikitaved mentioned this pull request Dec 1, 2020
Closed
@nikitaved nikitaved requested a review from gchanan Dec 1, 2020
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot facebook-github-bot commented Dec 2, 2020

@albanD merged this pull request in 3b25af0.

shaibagon added a commit to shaibagon/pytorch that referenced this issue Dec 3, 2020
@nikitaved @shaibagon
matrix_exp + matrix_exp.backward complex support (pytorch#48363)
4d3fa6c 
Summary:
As per title. Fixes pytorch#48299.

Pull Request resolved: pytorch#48363

Reviewed By: ejguan

Differential Revision: D25224498

Pulled By: albanD

fbshipit-source-id: 0c80ffb03ccfc46ab86398911edfba0b09049e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@facebook-github-bot facebook-github-bot

@albanD albanD

@gchanan gchanan

Assignees
No one assigned
Labels
cla signed complex_autograd Merged module: complex open source triaged
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

torch.matrix_exp gives incorrect results for complex tensors
5 participants
@nikitaved @facebook-github-bot @albanD @pytorchbot @mruberry