Skip to content

/ maddy

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: Future.Set called multiple times #270

Open
egorsmkv opened this issue Sep 10, 2020 · 5 comments
Open

panic: Future.Set called multiple times #270

egorsmkv opened this issue Sep 10, 2020 · 5 comments
Labels
bug help wanted

Comments

@egorsmkv
Copy link

@egorsmkv egorsmkv commented Sep 10, 2020 •
edited

Describe the bug

I have got a panic during sending a message:

Sep 10 08:55:45 mailserver maddy[2079]: panic: Future.Set called multiple times
Sep 10 08:55:45 mailserver maddy[2079]: goroutine 4873 [running]:
Sep 10 08:55:45 mailserver maddy[2079]: github.com/foxcpp/maddy/framework/future.(*Future).Set(0xc000281900, 0x556b49201c00, 0xc0003ac640, 0x556b4933b500, 0xc0003ac620)
Sep 10 08:55:45 mailserver maddy[2079]:         github.com/foxcpp/maddy/framework/future/future.go:54 +0x10e
Sep 10 08:55:45 mailserver maddy[2079]: github.com/foxcpp/maddy/internal/target/remote.(*daneDelivery).PrepareConn.func1(0xc000300560, 0x556b4934d4e0, 0xc0003c6d20, 0xc0003f5460, 0x1b)
Sep 10 08:55:45 mailserver maddy[2079]:         github.com/foxcpp/maddy/internal/target/remote/security.go:400 +0x225
Sep 10 08:55:45 mailserver maddy[2079]: created by github.com/foxcpp/maddy/internal/target/remote.(*daneDelivery).PrepareConn
Sep 10 08:55:45 mailserver maddy[2079]:         github.com/foxcpp/maddy/internal/target/remote/security.go:397 +0xcd
Sep 10 08:55:45 mailserver systemd[1]: maddy.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
Sep 10 08:55:45 mailserver systemd[1]: maddy.service: Failed with result 'exit-code'.

Steps to reproduce

  1. Just sent an email to two addresses on gmail.com and icloud.com

I tried to reproduce this issue but it seems it happened spontaneously.

Configuration file

It's the standard config file, except another domain name.

Environment information

  • maddy version: maddy 0.4.0+gf9d5c0c linux/amd64 go1.15.2

I've installed maddy from the source code.
@egorsmkv egorsmkv added the bug label Sep 10, 2020
@egorsmkv
Copy link
Author

@egorsmkv egorsmkv commented Sep 10, 2020

A link to the code line where the issue makes its panic: https://github.com/foxcpp/maddy/blob/master/internal/target/remote/security.go#L400
@foxcpp
Copy link
Owner

@foxcpp foxcpp commented Sep 19, 2020

For reference: Both gmail.com and icloud.com do not have any DANE records set.
@Butzlabben
Copy link

@Butzlabben Butzlabben commented Oct 14, 2020

The error is still present. Do you need any further information @foxcpp ?
foxcpp added a commit that referenced this issue Oct 17, 2020
@foxcpp
future: Do not crash server when Future.Set is called multiple times
Verified
This commit was signed with a verified signature.
foxcpp Max Mazurov
GPG key ID: 5B991F6215D2FCC0 Learn about signing commits
Loading status checks…
c3987e3 
Temporary patch for #270 as I am unable to identify the root cause.
@foxcpp
Copy link
Owner

@foxcpp foxcpp commented Oct 17, 2020

I am unable to identify the root cause of the issue. Just stress testing sending mail to two domains with DANE checking enabled is not revealing anything.

I pushed c3987e3 to master that masks the issue by ignoring duplicated Future.Set calls.
@foxcpp foxcpp added the help wanted label Oct 17, 2020
@foxcpp
Copy link
Owner

@foxcpp foxcpp commented Oct 17, 2020

And added slightly more logging in 0000256 for it. This likely has some relation to resolver errors and this is why it is not always happening since most DNS errors are transient.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@egorsmkv @Butzlabben @foxcpp
You can’t perform that action at this time.