Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for markdown reference-style link #925
Comments
|
#936 |
|
I'd be willing to help however I can for this also, although I might require some hand-holding at first. I can promise I will do my best to learn, though. Reference-style links are important enough for me to at least try to help. :) |
|
Hi, Good initiative @patdavid read vimwiki#base#follow_link. I am glad to see some motivation to contribute to vimwiki and try to make a code documentation whenever possible. @JasonMFry have a look at #1005. It may take 5h of reading code, to understand how plugin and ftplugin are adding commands linking to autoload/base which uses all other files. u.vim sandars for util and vars.vim is to keep all user configuration variable in one place as explained here. |
|
Little doc for the brave coder. Link reference definition convert: - [2020-07-11-three-weeks-in]
[2020-07-11-three-weeks-in]: blog/2020-07-11-three-weeks-in.md "Three Weeks In"in <ul>
<li><a href="blog/2020-07-11-three-weeks-in.md" title="Three Weeks In">2020-07-11-three-weeks-in</a></li>
</ul> |
|
@patdavid if you make the PR before November you gain 1/4 of Hacktoberfest T-shirt Yeepi |
|
@tinmarino I started using Vim this year and love it. Recently discovered this plugin and think it's wonderful for many applications. Not sure if anyone is still working on this but I'd love to give it a go. |
|
Hello @apruden2008, In absence of any return after a month, I may reafect it to another person. Don't feel stress or pushed thought, I said "return" not code, just a sign of life if someone pings here. Feel free to ask but you may not receive answers because there are so many tickets, sometimes I loose myself. |
|
Thanks. Quick clarification @patdavid on the implementation. Pressing right now creates an embedded link in vimwiki. Should there be some kind of flag the user can set to differentiate between embedded and reference style? Or should this reassign to only create reference style links? I personally prefer the option, so that's how I'm going to start implementing for now. |
|
Opcion: link_type = reference or web |
|
The regex patterns in here are dense. Any tips on how to decipher or how to get up to speed? I know some basic regex but this is very hard to parse: [[[^\]]{-}%(|[^\]]{-})?]]|[][]@<![[^\[]]{-}][][][]@ !|[][]@<![[^\[]]{-}][[^\[]]{-}][][]@! |
|
@apruden2008 good question. I think there is no way. |
|
No worries. I'm here to contribute to an open-source project that I like and use, not to earn a free t-shirt. Moreover, it's good practice. But I understand if you want to prioritize it and pass to a regex pro. But until then, I'll keep hacking at it and see what I can come up with. |
|
But I understand if you want to prioritize it and pass to a regex pro
No hurry, take your time, we have 140 open ticket so there is work for
every one.
…On Tue, 27 Oct 2020 at 00:50, apruden2008 ***@***.***> wrote:
No worries. I'm here to contribute to an open-source project that I like
and use, not to earn a free t-shirt. Moreover, it's good practice. But I
understand if you want to prioritize it and pass to a regex pro. But until
then, I'll keep hacking at it and see what I can come up with.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#925 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABOXDOXUQ6Y437YJLL2NFALSMY7SFANCNFSM4OEAMQBA>
.
|
|
Sorry, was afk for the weekend. I really have the best intentions to try and help out, but am stretched a bit thin at the moment so haven't had a chance to. I apologize. |
I'd like support for markdown reference-style links. I don't like using inline links b/c it makes the line length very long, and if I wrap the line it almost always breaks up the markdown link, which I also don't like. Support for reference-style links would address both of those issues.
This is what "support" means to me:
enteron a word creates a reference-style linkenteron a reference-style link takes you to the linkI've just started using vimwiki in the past week so maybe there are more things that "support" should mean but that's all I can think of.
I'm willing to put up a PR for this, especially if someone points me in the right directions to get started, but it may very well take months for me to finish b/c I don't have much free time.
This is related to #538