Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Profiler: Improve nested-update checks #20299
Merged
+93
−9
Conversation
Previous checks were too naive when it comes to pending lower-pri work or batched updates. This commit adds two new (previously failing) tests and fixes.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b16db5b:
|
| @@ -3016,6 +3098,8 @@ describe('Profiler', () => { | |||
| expect(Scheduler).toHaveYielded(['Component:true']); | |||
| expect(onNestedUpdateScheduled).not.toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| // TODO Add hydration tests to ensure we don't have false positives called. | |||
bvaughn
Nov 19, 2020
Author
Contributor
There might be other edge cases related to hydration or Suspense that I haven't thought about yet. This note is for me to follow up and think about them more.
There might be other edge cases related to hydration or Suspense that I haven't thought about yet. This note is for me to follow up and think about them more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Previous checks were too naive when it comes to pending lower-pri work or batched updates. This commit adds two new (previously failing) tests and fixes.