Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fixes `cppinsights` build with Clang-10 #296
Conversation
* `make tests` results: 254/297
|
Hello @AmeyaVS, thank you for your contribution. It is great that you tracked the LLVM commit which caused the change! You picked the hardest one. Switching the major Clang version also requires to update the CI-bots. I have patches which add Clang 10 support and fixes the tests. However, I needed time to wait for all the pre-build binaries. After that I will do a final test and then push it. Andreas |
|
Hello @andreasfertig, Thank you for the prompt response. Ameya |
|
You're welcome! And yes it does help :-) Andreas |
|
Let me know if there are any changes required to the patch, I would gladly update for it to be merged cleanly. Ameya |
|
Thank you. As it is a bit more code due to backwards compatibility and the test I decided to create a new patch. It also contains switching of the CI pipeline and Docker image updates. But thank you. As initially said, this is the hardest time for a patch. After the switch to Clang 10, patches are easier. Andreas |
make testsresults: 254/297Refer here for upstream changes in llvm-project