Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes `cppinsights` build with Clang-10 #296

Open
wants to merge 1 commit into
base: master
from

Conversation

@AmeyaVS
Copy link

@AmeyaVS AmeyaVS commented Apr 1, 2020

  • make tests results: 254/297

Refer here for upstream changes in llvm-project

* `make tests` results: 254/297
@andreasfertig
Copy link
Owner

@andreasfertig andreasfertig commented Apr 1, 2020

Hello @AmeyaVS,

thank you for your contribution. It is great that you tracked the LLVM commit which caused the change! You picked the hardest one. Switching the major Clang version also requires to update the CI-bots. I have patches which add Clang 10 support and fixes the tests. However, I needed time to wait for all the pre-build binaries. After that I will do a final test and then push it.
Hope you understand this. I try to have the transition finished by end of next week as latest.

Andreas

@AmeyaVS
Copy link
Author

@AmeyaVS AmeyaVS commented Apr 1, 2020

Hello @andreasfertig,

Thank you for the prompt response.
I knew it is going to break the build on CI.
Anyway, I wanted to push the changes for my own experimentation on Clang 10.
Hope this helps in some way.

Ameya

@andreasfertig
Copy link
Owner

@andreasfertig andreasfertig commented Apr 1, 2020

You're welcome! And yes it does help :-)

Andreas

@AmeyaVS
Copy link
Author

@AmeyaVS AmeyaVS commented Apr 2, 2020

Let me know if there are any changes required to the patch, I would gladly update for it to be merged cleanly.

Ameya

@andreasfertig
Copy link
Owner

@andreasfertig andreasfertig commented Apr 4, 2020

Thank you. As it is a bit more code due to backwards compatibility and the test I decided to create a new patch. It also contains switching of the CI pipeline and Docker image updates. But thank you. As initially said, this is the hardest time for a patch. After the switch to Clang 10, patches are easier.

Andreas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.