Skip to content

/ hydra

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing documentation for config key oidc.subject_identifiers.supported_types #2182

Closed
gpor0 opened this issue Nov 17, 2020 · 2 comments
Closed

Missing documentation for config key oidc.subject_identifiers.supported_types #2182

gpor0 opened this issue Nov 17, 2020 · 2 comments
Labels
bug docs good first issue help wanted
Projects
Maintainer's Board

Comments

@gpor0
Copy link

@gpor0 gpor0 commented Nov 17, 2020

Describe the bug

After Hydra startup log warns about configuration key deprecation. There is no records in documentation reference (https://www.ory.sh/hydra/docs/reference/configuration/) about oidc.subject_identifiers.supported_types.

Reproducing the bug

Steps to reproduce the behavior:

Start Hydra Hydra v1.9.0-alpha.2 with oidc.subject_identifiers.enabled set to public

Server logs

Configuration key oidc.subject_identifiers.enabled is deprecated and will be removed in a future release. Use key oidc.subject_identifiers.supported_types instead! audience=application service_name= service_version=
Thank you for using ORY Hydra v1.9.0-alpha.2!

Configuration

oidc:
  subject_identifiers:
    enabled:
       - public

Expected behavior

oidc.subject_identifiers.supported_types should be documented.
@zepatrik
Copy link
Member

@zepatrik zepatrik commented Nov 18, 2020 •
edited

Right, this has to be changed here: https://github.com/ory/hydra/blob/master/.schema/config.schema.json#L503-L571

This change was introduced with #1706 but the config schema was not updated there.
@aeneasr aeneasr self-assigned this Nov 18, 2020
@aeneasr aeneasr added this to To do in Maintainer's Board via automation Nov 18, 2020
@aeneasr aeneasr removed their assignment Nov 18, 2020
@aeneasr
Copy link
Member

@aeneasr aeneasr commented Dec 2, 2020

Closed via #2211
@aeneasr aeneasr closed this Dec 2, 2020
Maintainer's Board automation moved this from To do to Done Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug docs good first issue help wanted
Projects
Maintainer's Board
  
Done
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@aeneasr @zepatrik @gpor0
You can’t perform that action at this time.