Skip to content

Fix git plus ssh test according to latest changes in Theia#18374

Merged
musienko-maxim merged 1 commit intomasterfrom
fix-locators
Dec 3, 2020
Merged

Fix git plus ssh test according to latest changes in Theia#18374
musienko-maxim merged 1 commit intomasterfrom
fix-locators

Conversation

@musienko-maxim
Copy link
Contributor

@musienko-maxim musienko-maxim commented Nov 15, 2020

What does this PR do?

  • Fix locators and update methods according to latest changes in Theia project

@che-bot che-bot added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/bug Outline of a bug - must adhere to the bug report template. labels Nov 15, 2020
@che-bot
Copy link
Contributor

che-bot commented Nov 16, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Ohrimenko1988
Ohrimenko1988 reviewed Nov 16, 2020
View reviewed changes
Ohrimenko1988
Ohrimenko1988 reviewed Nov 16, 2020
View reviewed changes
Ohrimenko1988
Ohrimenko1988 reviewed Nov 16, 2020
View reviewed changes
@che-bot
Copy link
Contributor

che-bot commented Nov 17, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@musienko-maxim
Copy link
Contributor Author

musienko-maxim commented Nov 30, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Nov 30, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@musienko-maxim
change locators accordind to latest changes in Theia.
2f1879d 
Signed-off-by: Musienko Maksym <mmusiien@redhat.com>
@musienko-maxim musienko-maxim mentioned this pull request Dec 2, 2020
Closed
@che-bot
Copy link
Contributor

che-bot commented Dec 2, 2020

❌ E2E Happy path tests failed ❗

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

@Katka92
Copy link
Contributor

Katka92 commented Dec 3, 2020

[crw-ci-test]

@che-bot
Copy link
Contributor

che-bot commented Dec 3, 2020

✅ E2E Happy path tests succeed 🎉

See Details

Tested with Eclipse Che Multiuser User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

dmytro-ndp
dmytro-ndp approved these changes Dec 3, 2020
View reviewed changes
Copy link
Contributor

@dmytro-ndp dmytro-ndp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git Ssh nightly tests have passed successfully https://codeready-workspaces-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/basic-MultiUser-Che-check-e2e-tests-against-k8s/3070/

@musienko-maxim musienko-maxim merged commit c55ddf2 into master Dec 3, 2020
@musienko-maxim musienko-maxim deleted the fix-locators branch December 3, 2020 15:50
@che-bot che-bot removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ohrimenko1988 Ohrimenko1988 Ohrimenko1988 approved these changes

@dmytro-ndp dmytro-ndp dmytro-ndp approved these changes

@nickboldt nickboldt Awaiting requested review from nickboldt

@rhopp rhopp Awaiting requested review from rhopp

Assignees

No one assigned

Labels

kind/bug Outline of a bug - must adhere to the bug report template.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@musienko-maxim @che-bot @Katka92 @dmytro-ndp @Ohrimenko1988