Skip to content

/ arduino-create-agent-js-client

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check all ports on agent disconnect #399

Merged
merged 2 commits into from Nov 25, 2020
Merged

check all ports on agent disconnect #399

merged 2 commits into from Nov 25, 2020

Conversation

@AlbyIanna
Copy link
Contributor

@AlbyIanna AlbyIanna commented Nov 25, 2020 •
edited

When the agent crashes, it's very likely that when the users re-launch it will run on a different port. This is causing bugs on every app that uses this lib because there's no way to find it again when this happens.
@AlbyIanna
check all ports on agent disconnect
2a6ad52
@AlbyIanna AlbyIanna requested review from smellai and pirropirro Nov 25, 2020
@pirropirro
pirropirro approved these changes Nov 25, 2020
View changes
Copy link
Contributor

@pirropirro pirropirro left a comment

LGTM
@smellai
smellai approved these changes Nov 25, 2020
View changes
@AlbyIanna
2.3.5
fa9d234
@AlbyIanna AlbyIanna merged commit eb11a73 into master Nov 25, 2020
@AlbyIanna AlbyIanna deleted the check-all-ports-on-disconnect branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smellai smellai

@pirropirro pirropirro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@AlbyIanna @smellai @pirropirro
You can’t perform that action at this time.