Inconsistent return types in clojure.data/diff tuple #296

kennyjwilli · 2019-05-06T20:53:52Z

I expected the result of diff to be a tuple of a list of Datoms or nil for things-only-in-a, things-only-in-b, and things-in-both. things-in-both is allowed to be a list of Datoms, nil, or a DB. Is this expected?

Expected return type
Actual return type:
[([datascript/Datom] | nil) ([datascript/Datom] | nil) ([datascript/Datom] | nil) ]

Actual return type
[([datascript/Datom] | nil) ([datascript/Datom] | nil) ([datascript/Datom] | datascript/DB | nil) ]

Examples

(clj-data/diff
  (d/db-with (d/empty-db) [])
  (d/db-with (d/empty-db) []))
=> [nil nil #datascript/DB{:schema nil, :datoms []}]

(clj-data/diff
  (d/db-with (d/empty-db) [{:a "a"}])
  (d/db-with (d/empty-db) [{:a "a"}]))
=> [nil nil #datascript/DB{:schema nil, :datoms [[1 :a "a" 536870913]]}]

(clj-data/diff
  (d/db-with (d/empty-db) [{:a "a"}])
  (d/db-with (d/empty-db) [{:a "a"}
                           {:b "b"}]))
=> [nil [#datascript/Datom[2 :b "b" 536870913 true]] [#datascript/Datom[1 :a "a" 536870913 true]]]

tonsky · 2019-05-07T12:21:44Z

Good catch! No, this is not expected. Probably a bug

tonsky / datascript

Inconsistent return types in clojure.data/diff tuple #296

Inconsistent return types in clojure.data/diff tuple #296

kennyjwilli commented May 6, 2019

tonsky commented May 7, 2019

tonsky / datascript

Sponsor tonsky/datascript

Join GitHub today

Inconsistent return types in clojure.data/diff tuple #296

Inconsistent return types in clojure.data/diff tuple #296

Comments

kennyjwilli commented May 6, 2019

tonsky commented May 7, 2019

Essential cookies

Always active

Analytics cookies