Skip to content

/ serving

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an E2E test covering autoscaling using HPA #9553

Open
markusthoemmes opened this issue Sep 24, 2020 · 1 comment
Open

Add an E2E test covering autoscaling using HPA #9553

markusthoemmes opened this issue Sep 24, 2020 · 1 comment
Labels
area/autoscale good first issue help wanted

Comments

@markusthoemmes
Copy link
Contributor

@markusthoemmes markusthoemmes commented Sep 24, 2020

We currently only test our autoscaling behavior for concurrency and rps. We should add an e2e test that also asserts we properly scale on cpu and memory.

The existing autoscale image has the necessary functions for that already (prime generation to consumpe CPU and memory bloating to consume memory).

We should add a test that sends a few requests to make sure the service eventually scales to > 1, then stop traffic and assert it eventually scales back to 1.
@knative-prow-robot
Copy link
Contributor

@knative-prow-robot knative-prow-robot commented Sep 24, 2020

@markusthoemmes:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

We currently only test our autoscaling behavior for concurrency and rps. We should add an e2e test that also asserts we properly scale on cpu and memory.

The existing autoscale image has the necessary functions for that already (prime generation to consumpe CPU and memory bloating to consume memory).

We should add a test that sends a few requests to make sure the service eventually scales to > 1, then stop traffic and assert it eventually scales back to 1.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@arghya88 arghya88 removed their assignment Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/autoscale good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@markusthoemmes @arghya88 @knative-prow-robot
You can’t perform that action at this time.