Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Replace deprecated elements in imposm3 schema #62
Conversation
Per current imposm3 code: https://github.com/omniscale/imposm3/blob/5816161a40f24446c1cebfe2c2158d6a2e5a3d8c/example-mapping.json * `pseudoarea` deprecated end of 2016, replaced with `webmerc_area` * `exclude_tags` deprecated beginning of 2017, replaced with `reject` * `fields` deprecated end of 2017, replaced with `columns`
|
Does it mean that user needs to use a specific version of imposm3? if yes, which one? |
|
See my comment about version of imposm3. Looks good to me (feel free to ping me to urge merge after answering my question ;) |
|
This looks good to merge (@tacatac probably is referring to imposm2 versus imposm3) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Per current imposm3 code:
https://github.com/omniscale/imposm3/blob/5816161a40f24446c1cebfe2c2158d6a2e5a3d8c/example-mapping.json
pseudoareadeprecated end of 2016, replaced withwebmerc_areaexclude_tagsdeprecated beginning of 2017, replaced withrejectfieldsdeprecated end of 2017, replaced withcolumns