Skip to content

/ probability

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BFGS user should be able to pass parameters to the line search #1043

Open
axch opened this issue Aug 5, 2020 · 1 comment · May be fixed by #1070
Open

BFGS user should be able to pass parameters to the line search #1043

axch opened this issue Aug 5, 2020 · 1 comment · May be fixed by #1070
Labels
good first issue

Comments

@axch
Copy link
Collaborator

@axch axch commented Aug 5, 2020

This should just be a matter of accepting a dict named line_search_kwargs or such and passing it through to the actual line search.

This was a feature request that came out of discussing #1034.
@axch axch mentioned this issue Aug 5, 2020
Closed
@rushabh-v rushabh-v linked a pull request that will close this issue Aug 30, 2020
Open
@axch
Copy link
Collaborator Author

@axch axch commented Aug 30, 2020

Clarification: The purpose is for the user to be able to control the parameters of the actual line search algorithm, of which only linesearch.hager_zhang is currently implemented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

add argument `line_search_kwargs` to BFGS
1 participant
@axch
You can’t perform that action at this time.