New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework Mail System #3710
Merged
Merged
Rework Mail System #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octol1ttle
suggested changes
Oct 5, 2020
86c3914
to
fe1fef9
Compare
mdcfe
previously requested changes
Jan 23, 2021
Essentials/src/main/java/com/earth2me/essentials/messaging/IMessageRecipient.java
Outdated
Show resolved
Hide resolved
JRoy
commented
Jan 23, 2021
JRoy
commented
Jan 23, 2021
Essentials/src/main/java/com/earth2me/essentials/messaging/SimpleMessageRecipient.java
Outdated
Show resolved
Hide resolved
kashike
reviewed
Jan 25, 2021
Essentials/src/main/java/net/essentialsx/api/v2/services/mail/MailMessage.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/net/essentialsx/api/v2/services/mail/MailMessage.java
Outdated
Show resolved
Hide resolved
|
Moving to draft as this is pending #4072 being merged |
# Conflicts: # Essentials/src/main/java/com/earth2me/essentials/UserData.java # Essentials/src/main/java/com/earth2me/essentials/config/holders/UserConfigHolder.java
zml2008
suggested changes
Jun 11, 2021
Essentials/src/main/java/com/earth2me/essentials/EssentialsUpgrade.java
Outdated
Show resolved
Hide resolved
thanks zml :))
3 tasks
mdcfe
requested changes
Jun 29, 2021
Essentials/src/main/java/net/essentialsx/api/v2/services/mail/Mail.java
Outdated
Show resolved
Hide resolved
mdcfe
reviewed
Jul 1, 2021
mdcfe
approved these changes
Jul 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
module: main
Issues or PRs for the main Essentials module
type: api
Issue/Pull Request regards user-facing API
type: enhancement
Features and feature requests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
/mail sendtemp <time diff> <message>command to send mail that will self-destruct after time diff./mail clear <number>command to clear a specific mail item./mail readnow tracks which mails you read and won't nag you about them.No longer relavant json format since new format will serialize to YAML using configurate object mappersMail Schema:
{ "mail": [ { "read": false, //bool which if true will show the mail item as gray italic to the user when read otherwise white "sender": "JRoy", //String because fetching User objects sounds like a bad idea "uuid": "abcde-abcd-acd12-12334", // Not currently used but stored for possible future use of for a server admin's reference "timestamp": 1234567890, //Epoch allows timestamp format to be changed (or per-player timezones in the future) "expire": 1234567890, //Epoch at which this mail should be deleted and not shown to the user or 0 if it does not expire "message": "Cool message, yo" //Actual message, possibly with color codes }, { "read": false, //bool which if true will show the mail item as gray italic to the user when read otherwise white "legacy": true, //bool but Value of this doesn't matter as it just instructs the parser to not expect the other *unknown* values "message": "JRoy: this is a message that was sent before fancy system" //Actual message } ] }Closes #364
Closes #1527
Closes #1860
Closes #3097