Skip to content

/ slider

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refator: Use father #641

Merged
merged 13 commits into from Mar 23, 2020
Merged

refator: Use father #641

merged 13 commits into from Mar 23, 2020

Conversation

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Mar 23, 2020

代码比较陈旧，用继承实现的功能。完全定义类型反而 TS 跑不过了。
zombieJ added 12 commits Mar 23, 2020
@zombieJ
init father
Loading status checks…
f9ca0aa
@zombieJ
rm warning deps
Loading status checks…
09b6802
@zombieJ
fix lint
Loading status checks…
15237c0
@zombieJ
slider tsx
c2cab58
@zombieJ
Slider tsx
Loading status checks…
f5067fb
@zombieJ
Range tsx
Loading status checks…
dd5b6c5
@zombieJ
handle tsx
43595cc
@zombieJ
createSliderWithTooltip
Loading status checks…
59e3892
@zombieJ
rest
c989cec
@zombieJ
fix lint
Loading status checks…
514ea13
@zombieJ
examples
Loading status checks…
0b17184
@zombieJ
fix ts
Loading status checks…
8d116c6
@zombieJ zombieJ requested a review from afc163 Mar 23, 2020
@vercel
Copy link

@vercel vercel bot commented Mar 23, 2020 •
edited

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/react-component/slider/jvbu6w09a
✅ Preview: https://slider-git-father.react-component.now.sh
@afc163
afc163 approved these changes Mar 23, 2020
View changes
@zombieJ
fix ci
Loading status checks…
7f50dff
@codecov
Copy link

@codecov codecov bot commented Mar 23, 2020 •
edited

Codecov Report

Merging #641 into master will decrease coverage by 7.33%.
The diff coverage is 87.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #641      +/-   ##
==========================================
- Coverage    95.4%   88.06%   -7.34%     
==========================================
  Files           2       10       +8     
  Lines          87      687     +600     
  Branches       29      182     +153     
==========================================
+ Hits           83      605     +522     
- Misses          4       82      +78
Impacted Files Coverage Δ
src/index.tsx 100% <ø> (ø)
src/common/Track.tsx 100% <100%> (ø)
src/common/createSlider.tsx 94.63% <100%> (ø)
src/Handle.tsx 88.88% <100%> (ø)
src/createSliderWithTooltip.tsx 96.15% <100%> (ø)
src/Range.tsx 75.67% <66.66%> (ø)
src/Slider.tsx 92.22% <68.42%> (ø)
src/common/Steps.tsx 96% <90.9%> (ø)
src/utils.ts 94.04% <94.04%> (ø)
src/common/Marks.tsx 96.29% <96.29%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f2630f...7f50dff. Read the comment docs.
@zombieJ zombieJ merged commit b5a337e into master Mar 23, 2020
5 of 7 checks passed
5 of 7 checks passed
codecov/patch 87.55% of diff hit (target 95.4%)
Details
codecov/project 88.06% (-7.34%) compared to 6f2630f
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
now Deployment has completed
Details
@delete-merged-branch delete-merged-branch bot deleted the father branch Mar 23, 2020
This was referenced May 19, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zombieJ @afc163
You can’t perform that action at this time.