Hi there 👋
I'm an engineer at Google Cloud. Previously I worked at HashiCorp, Chef Software, CustomInk, and some Pittsburgh-based startups.
💬 Ask me about: Go, Ruby😄 Pronouns: he/him🌍 Website
sethvargo
Follow
Pinned
3,025 contributions in the last year
Activity overview
Contributed to
google/exposure-notifications-verification-server,
google/exposure-notifications-server,
google-github-actions/setup-gcloud
and 5 other
repositories
Contribution activity
December 2020
Created 63 commits in 3 repositories
Created a pull request in google/exposure-notifications-verification-server that received 4 comments
Introduce RBAC
This introduces Role-Based Access Controls (RBAC) into the system. Common operations in the system are split into Read (view-only) and Write (creat…
+2,703
−1,878
•
4
comments
Opened 60 other pull requests in 2 repositories
google/exposure-notifications-verification-server
53
merged
- Make bad query params a user error
- Add full integration test coverage for API keys
- Improve UX on permissions selection
- Update deps
- Don't close chaff on routes return
- Show bad path 404s
- Extract trace context if present and add to logger
- Make SMS message failures info level
- Wait for Redis connections to become available
- Document implied permissions, enforce via javascript
- Don't allow admin API keys to read stats
- Mount Apache logger in binary
- Add ph translations
- Add descriptions for rbac permissions
- Add API key type for accessing statistics
- Only create Apache logs for local dev
- Add statistics endpoints to adminapi
- Only display daily actives graph if enabled
- Make daily active stats collection a realm configurable
- Extract adminapi and apiserver routes into internal/
- Do not return 500s from redirect service for missing realms
- Add linters for Terraform
- Improve test coverage for database package
- Redirect back if bulk upload is not enabled
- Properly redirect to login when required
- Some pull requests not shown.
google/exposure-notifications-server
7
merged
Reviewed 93 pull requests in 3 repositories
google/exposure-notifications-verification-server 73 pull requests
- Part 1: refactor issue-code
- Add full integration test coverage for API keys
- separate batch-issue from other e2e flows
- Test for single issue code
- Let CI print out git diff
- Terraform destroy first remove database from state
- Use envvar to increase stackdriver timeout to 1min.
- Adding an test for bulk-issue error handling
- Add specific instructions for Error Burn playbook
- Remember user's SMS template preference
- Add terraform lock to source control
- Update google provider to 3.51
- Add implied permissions - write permissions need read permissions to be useful
- Create a no-op failure SMS provider
- Factor out test server config from the test server
- Mount Apache logger in binary
- Add API key type for accessing statistics
- Add RBAC check to issue_batch api
- e2e coverage for BatchIssueCode API
- Disable SLO alerts except for adminapi/apiserver/server.
- Update variable names used in the SLO modules to be more consistent.
- Do not return 500s from redirect service for missing realms
- Fix log_config terraform config.
- Improve test coverage for database package
- Add SMS template choice to bulk-uploader
- Some pull request reviews not shown.
google/exposure-notifications-server 19 pull requests
- Terraform: add hash from CI runner
- Terraform destroy first remove database from state
- Add terraform lock to source control
- Update google provider to 3.51
- Update notification channel setting in key server.
- Adjust Stackdriver export timeout to 1 minute.
- Upgrade terraform to 0.14.2 in presubmit test image
- Add a knob to enable Load Balancer logging.
- Exclude a rule in Cloud Armor.
- additional data defaults when importing keys from export files
- Terraform: VPC connector depends on service networking connection
- Remove the reference to the metrics middleware.
- deflake test
- don't stop retrying azure credential refresh on single failure
- allow for max records to be overridden on a per-export-config basis
- add tool to visualize links in an export file
- Unit test testing large batch exports
- Fix the MQL query, remove group by type.
- Adjust latency alert threshold
sethvargo/go-githubactions 1 pull request
Created an issue in google/exposure-notifications-verification-server that received 4 comments
Refactor VerificationCode.Validate to separate user error from system error
At present, VerificationCode.Validate returns an error for user error (e.g. invalid symptom onset date) and system error (e.g. code too short).
We …
4
comments
Opened 13 other issues in 2 repositories
google/exposure-notifications-verification-server
4
open
8
closed
- ErrTestTooOld is hard coded to 14 days
- RBAC Write permissions should include Read
- Provide API endpoints for accessing statistics
- Alert when a human accesses a secret
- Allow bulk management of user permissions
- Add descriptions for RBAC roles
- Test migration from pre-RBAC to post-RBAC
- Write a test that migration numbers are strictly increasing
- Check 401 permissions to sign out
- Pass through Twilio 4xx errors to the caller
- Captcha fails to load on failed login
- Per-day per-user stats visualization
google/exposure-notifications-server
1
closed
29
contributions
in private repositories
Dec 1 – Dec 18