sanitize-html returns a string 'undefined' when content is empty, I c… #598
Conversation
…hanged this string to an empty paragraph
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
According to this issue apostrophecms/sanitize-html#81, the sanitize-html may return 'undefined' string when episode content is empty.
I made episode.js change this 'undefined' string for an empty paragraph.
I also tried to persist an empty string as content, instead of
<p></p>, but PodcastEpisode.js understand empty content as an error and shows an error message.