Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xhr-basic.html #320

Merged
merged 2 commits into from Dec 18, 2020
Merged

Update xhr-basic.html #320

merged 2 commits into from Dec 18, 2020

Conversation

@webdev4422
Copy link
Contributor

@webdev4422 webdev4422 commented Dec 15, 2020

Change 'var' to 'const, let', so it relate to ajax-finish.html

Change 'var' to 'const, let', so it relate to ajax-finish.html
Copy link
Collaborator

@chrisdavidmills chrisdavidmills left a comment

Hi @mrxdkox ! Thanks for fixing this up.

I just had one comment for you to address, but apart from that we are good to go.


verseChoose.onchange = function() {
var verse = verseChoose.value;
verse = verseChoose.value;

This comment has been minimized.

@chrisdavidmills

chrisdavidmills Dec 17, 2020
Collaborator

This needs a const

This comment has been minimized.

@webdev4422

webdev4422 Dec 18, 2020
Author Contributor

Got it, thx.

Copy link
Collaborator

@chrisdavidmills chrisdavidmills left a comment

Great, thanks!

@chrisdavidmills chrisdavidmills merged commit aadc63c into mdn:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.