fmt lsp, utilize DocumentUri, add methods#19
Merged
danieldaeschle merged 10 commits intomasterfrom Dec 16, 2020
Merged
Conversation
lsp/lsp.v
Outdated
| type DocumentUri = string | ||
|
|
||
| pub fn (du DocumentUri) str() string { | ||
| return du |
Member
There was a problem hiding this comment.
just asking. is this needed?
Contributor
Author
There was a problem hiding this comment.
Related to testing. See the updated commit for an updated version
Member
There was a problem hiding this comment.
You don't need a str() method. This works on my PC:
type DocUri = string
fn main() {
uri := DocUri('test')
println(uri.str() == 'test')
}|
|
||
| fn test_document_uri_from_path() { | ||
| input := '/foo/bar/test.v' | ||
| assert document_uri_from_path(input).str() == 'file:///foo/bar/test.v' |
Member
There was a problem hiding this comment.
document_uri_from_path(input) == 'file:///foo/bar/test.v' doesn't work?
Contributor
Author
There was a problem hiding this comment.
it produces a c error for some reason. i will revert the change if you want and place it in a separate variable
Member
There was a problem hiding this comment.
if that works, yes. i want to prevent custom str() methods if possible.
Contributor
Author
There was a problem hiding this comment.
Still causes a C gen error apparently 🙁 I've added a note about it
nedpals
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #10