Skip to content

/ Steeltoe

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commons updates for Streams #224

Merged
merged 7 commits into from Jan 29, 2020
Merged

Commons updates for Streams #224

merged 7 commits into from Jan 29, 2020

Conversation

@dtillman
Copy link
Contributor

@dtillman dtillman commented Jan 29, 2020

No description provided.

@dtillman
Commons updates for Streams
Loading status checks…
141fe1c
@codecov
Copy link

@codecov codecov bot commented Jan 29, 2020 •
edited

Codecov Report

Merging #224 into master will increase coverage by 1.6%.
The diff coverage is 70.34%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #224     +/-   ##
=========================================
+ Coverage   54.14%   55.75%   +1.6%     
=========================================
  Files         646      703     +57     
  Lines       18477    20599   +2122     
  Branches     3350     3881    +531     
=========================================
+ Hits        10005    11485   +1480     
- Misses       7628     8110    +482     
- Partials      844     1004    +160
Impacted Files Coverage Δ
.../src/Common.Security/PemConfigurationExtensions.cs 100% <ø> (ø) ⬆️
...mmon/src/Common.Security/PemCertificateProvider.cs 85.71% <ø> (ø) ⬆️
...alancer/LoadBalancerHttpClientBuilderExtensions.cs 100% <ø> (ø) ⬆️
src/Common/src/Common.Net/MPR.cs 0% <ø> (ø) ⬆️
...rc/Common/src/Abstractions/Util/AtomicReference.cs 70% <0%> (ø) ⬆️
...ommon/src/Common/Expression/ExpressionException.cs 0% <0%> (ø)
.../Common/src/Common/Lifecycle/LifecycleException.cs 0% <0%> (ø)
.../src/Common/Expression/CSharp/EvaluationContext.cs 0% <0%> (ø)
...Common/src/Common/Util/ExceptionDepthComparator.cs 0% <0%> (ø)
src/Common/src/Common/Order/AbstractOrdered.cs 0% <0%> (ø)
... and 122 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 690489f...04b9b78. Read the comment docs.
@TimHess
TimHess reviewed Jan 29, 2020
View changes
.editorconfig Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Abstractions/Converter/IConverterRegistry.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Abstractions/Converter/IConverterRegistry.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Abstractions/Converter/IGenericConverter.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Abstractions/Converter/IGenericConverter.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Common/Converter/ArrayToCollectionConverter.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Abstractions/Util/IRunnable.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Abstractions/Util/IAsyncRunnable.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Common/Converter/CollectionToCollectionConverter.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Common/Converter/CollectionToCollectionConverter.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Common/Expression/CSharp/EvaluatioinContext.cs Outdated Show resolved Hide resolved
@TimHess
TimHess reviewed Jan 29, 2020
View changes
src/Common/src/Common/Converter/StringToBooleanConverter.cs Outdated Show resolved Hide resolved
@TimHess
Fix typos
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4401c5b
@TimHess
TimHess reviewed Jan 29, 2020
View changes
@dtillman @TimHess
Update src/Common/src/Common/Expression/CSharp/EvaluatioinContext.cs
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
547414b 
Co-Authored-By: Tim Hess <[email protected]>
dtillman and others added 4 commits Jan 29, 2020
@dtillman @TimHess
Update src/Common/src/Common/Converter/CollectionToCollectionConverte…
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8e14ced 
…r.cs

Co-Authored-By: Tim Hess <[email protected]>
@TimHess
disable S3925 warnings for sonar
Loading status checks…
2c61d90
@dtillman
Use Linq extension method for comparision
Loading status checks…
ec1017a
@TimHess
fix typo in file name
Loading status checks…
04b9b78
@TimHess
TimHess approved these changes Jan 29, 2020
View changes
@TimHess
TimHess approved these changes Jan 29, 2020
View changes
@dtillman dtillman merged commit 807dfef into master Jan 29, 2020
5 checks passed
5 checks passed
SteeltoeOSS.steeltoe Build #3.0.0-1630 succeeded
Details
SteeltoeOSS.steeltoe (Linux_Build_and_Test) Linux_Build_and_Test succeeded
Details
SteeltoeOSS.steeltoe (MacOS_Build_and_Test) MacOS_Build_and_Test succeeded
Details
SteeltoeOSS.steeltoe (Windows_Build_Test_and_Package) Windows_Build_Test_and_Package succeeded
Details
license/cla All CLA requirements met.
Details
@sonarcloud
Copy link

@sonarcloud sonarcloud bot commented Jan 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 3 Security Hotspots to review)
Code Smell A 51 Code Smells

78.1% 78.1% Coverage
0.0% 0.0% Duplication
@TimHess TimHess added this to the 3.0.0-M1 milestone Feb 6, 2020
@TimHess TimHess deleted the streams-common-updates branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimHess TimHess

Assignees
No one assigned
Labels
Component/Common ReleaseLine/3.x
Projects
None yet
Milestone
3.0.0-M1
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@dtillman @TimHess
You can’t perform that action at this time.