Icon compatibility with Font Awesome 5 #612
Open
Conversation
Unified icon names to be compatible with FA 5.
| @@ -135,7 +135,7 @@ | |||
| <a n:href="showAllColumns!" class="ajax"><i n:block = "icon-eye" class="{$icon_prefix}eye"></i> {='ublaboo_datagrid.show_all_columns'|translate}</a> | |||
| </li> | |||
| <li n:if="$control->hasSomeColumnDefaultHide()"> | |||
| <a n:href="showDefaultColumns!" class="ajax"><i n:block = "icon-repeat" class="{$icon_prefix}repeat"></i> {='ublaboo_datagrid.show_default_columns'|translate}</a> | |||
| <a n:href="showDefaultColumns!" class="ajax"><i n:block = "icon-repeat" class="{$icon_prefix}redo"></i> {='ublaboo_datagrid.show_default_columns'|translate}</a> | |||
paveljanda
Feb 22, 2018
Member
That one (and only one) would break backward compatibility.
That one (and only one) would break backward compatibility.
radekdostal
Feb 22, 2018
Author
Contributor
"redo" should be an alias for "repeat". Same as "times" and "remove".
See https://fontawesome.com/v4.7.0/icons/ and search "redo".
"redo" should be an alias for "repeat". Same as "times" and "remove".
See https://fontawesome.com/v4.7.0/icons/ and search "redo".
paveljanda
Feb 22, 2018
Member
redo is not an icon in v4. Try it by yourself. :)
redo is not an icon in v4. Try it by yourself. :)
radekdostal
Feb 22, 2018
Author
Contributor
Hm. You are right.
There are more incompatible icons (FA4 -> FA5 - Free):
- repeat -> redo
- arrows -> arrows-alt
- check-square-o -> check-square (filled)
- square-o -> square (filled)
I don't know, how to support it. Add properties like DataGrid::$icon_prefix?
Hm. You are right.
There are more incompatible icons (FA4 -> FA5 - Free):
- repeat -> redo
- arrows -> arrows-alt
- check-square-o -> check-square (filled)
- square-o -> square (filled)
I don't know, how to support it. Add properties like DataGrid::$icon_prefix?
kleinpetr
Feb 25, 2018
•
Yes, maybe add property with version of FA ?
DataGrid::$fa_version, $icon_version or something like this ?
Yes, maybe add property with version of FA ?
DataGrid::$fa_version, $icon_version or something like this ?
kleinpetr
Feb 25, 2018
next one different icon is
gear -> cog
next one different icon is
gear -> cog
paveljanda
Feb 25, 2018
•
Member
fa-repeat souns quite OK to me. :)
fa-repeat souns quite OK to me. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Unified icon names to be compatible with FA 5.