In detach, don't try to copy MAP_SHARED pages#2775
Merged
rocallahan merged 1 commit intorr-debugger:masterfrom Dec 22, 2020
Merged
In detach, don't try to copy MAP_SHARED pages#2775rocallahan merged 1 commit intorr-debugger:masterfrom
rocallahan merged 1 commit intorr-debugger:masterfrom
Conversation
Any updates that were made to the page will already be visible, so there's no need to copy. Of course, applications that use MAP_SHARED are quite likely to break anyway, but we might as well let it continue here. There are some libraries that like to map global caches MAP_SHARED, even if they generally aren't written without manual update, which is usually fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any updates that were made to the page will already be visible,
so there's no need to copy. Of course, applications that use
MAP_SHARED are quite likely to break anyway, but we might
as well let it continue here. There are some libraries that
like to map global caches MAP_SHARED, even if they generally
aren't written without manual update, which is usually fine.