Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Function should only do one thing - Invalid example #275
Comments
|
Feel free to open a PR fixing this! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checking the db for "isClientActive" would likely return a promise, and this makes
clientRecord.isActivealways return false since clientRecord is actually a Promise which doesn't have isActive prop.. But even if fix that.. When we filter by this function for active clients we will get all record since this function returns a promise which evaluates totruewhen filtering