Update package.json#4041
Closed
Boefjim wants to merge 1 commit intophoenixframework:masterfrom
Boefjim:patch-1
Closed
Update package.json#4041Boefjim wants to merge 1 commit intophoenixframework:masterfrom Boefjim:patch-1
Boefjim wants to merge 1 commit intophoenixframework:masterfrom
Boefjim:patch-1
Conversation
Added "type": "module"
Member
|
We specify the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Added "type": "module"
Reason
Currently NodeJS will give the following error when trying to import phoenix.js:
The requested module 'phoenix' is expected to be of type CommonJS, which does not support named exports. CommonJS modules can be imported by importing the default export.Indicating that the type of the package is a module will fix this.