Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Repo info
Activity
  • 08:12
    Danrancan commented #1692
  • Dec 08 01:47
    sgj3 opened #1695
  • Dec 08 01:20
    sgj3 synchronize #1694
  • Dec 08 01:15
    sgj3 edited #1694
  • Dec 08 01:14
    sgj3 opened #1694
  • Dec 08 01:06
    sgj3 closed #1693
  • Dec 08 01:06
    sgj3 opened #1693
  • Dec 04 11:25
    PeterSurda commented #1692
  • Dec 04 11:08
    PeterSurda labeled #1692
  • Dec 04 11:08
    PeterSurda labeled #1692
  • Dec 04 11:08
    PeterSurda assigned #1692
  • Dec 03 23:39
    Danrancan opened #1692
  • Nov 25 17:30
    PeterSurda milestoned #1691
  • Nov 25 17:29
    PeterSurda labeled #1691
  • Nov 25 17:29
    PeterSurda labeled #1691
  • Nov 25 14:27
    navjotcis opened #1691
  • Nov 23 16:53
    navjotcis synchronize #1666
  • Nov 23 16:53
    navjotcis synchronize #1671
  • Nov 23 16:53
    navjotcis synchronize #1688
  • Nov 23 14:55
    PeterSurda closed #1665
Dmitri Bogomolov
@g1itch
I feel confused always being late to that train of deprecations ): PyQt4, python2.7 and even setuptools test command pypa/setuptools#1684
Peter Šurda
@PeterSurda
how about you look at the QT test PR and move those tests into your QT branch
those tests cover a lot of the interface
Dmitri Bogomolov
@g1itch
I unsubscribed from that PR because I don't like the bikeshed approach
Tests shouldn't require changes in code
They shouldn't print
There is no need for another top level package
Test cases usually don't load test cases
The tests subpackage of bitmessageqt is already in v0.6. It's loaded in tests.core
Dmitri Bogomolov
@g1itch
The changes done in #1603 is more like a demo, not tests
Peter Šurda
@PeterSurda
I see. The idea was to make it more of a functional test than a unit test.
Peter Šurda
@PeterSurda
How about then we have a last official release of p2 (once I get the binaries working), and then only focus on p3 development and switch the main branch when ready
p2 branch will be bugfix-only
Peter Šurda
@PeterSurda
@g1itch any idea why travis isn't reporting?
Dmitri Bogomolov
@g1itch
I have no idea. My rebases were reported.
Dmitri Bogomolov
@g1itch
Peter Šurda
@PeterSurda
ok
thanks
Peter Šurda
@PeterSurda
@g1itch there appear to be minor issues with dpkg as you can see from buildbot checks, e.g. permission issue with apparmor
Peter Šurda
@PeterSurda
list of packages in travis.yml isn't working for focal
Dmitri Bogomolov
@g1itch
use python2-<packagename> for focal
Peter Šurda
@PeterSurda
I know (some are still missing but not important now), but I want it fixed in .travis.yml
Dmitri Bogomolov
@g1itch
but .travis.yml is designed for xenial
Peter Šurda
@PeterSurda
what is your recommendation to get the test pass on focal
I can add the packages to the VM image for example
I was trying to avoid this so that the test can pass without having to have a special environment
Dmitri Bogomolov
@g1itch
I tried to add focal to my ci matrix and have not succeeded yet
the problem is with PyQt
Peter Šurda
@PeterSurda
ok
Let me modify travis2bash to skip missing
Dmitri Bogomolov
@g1itch
apt-get install -yq python-qt4 not works on install stage - python not sees the package
Peter Šurda
@PeterSurda
I now added -m
Dmitri Bogomolov
@g1itch
What's the permission issue? Did it appear after merge? I have not found it here: https://buildbot.bitmessage.org/#/builders/14/builds/542
Peter Šurda
@PeterSurda
I fixed focal build environment now. Let me check apt.
I think I may have been looking in the wrong place, it seems to be ok. Perhaps it was an older code, or one of your own test branches
The build is a bit slower now because there doesn't appear to be a way to autoskip unknown packages, so I install them one by one
but it works now so I'm happy
I'm going to add other linux distros now, and other OSes.
Dmitri Bogomolov
@g1itch
I noticed the absolute path in data_files ('/etc/apparmor.d/') and changed it before merge
cool
Peter Šurda
@PeterSurda
oh that's probably it
yes it was yesterday that I saw it
I have images for debian 9, 10, centos 6, 7, 8, fedora 32, so I'll work on these first.
I should have more servers shortly so more test can run in parallel
Dmitri Bogomolov
@g1itch
Fedora32 is unlikely to work. You can use my fedora31 Dockerfile as example: https://github.com/g1itch/PyBitmessage/blob/ci/packages/Dockerfile.fedora
Peter Šurda
@PeterSurda
Not important that it works now, just that the tests are available.
Peter Šurda
@PeterSurda
There is now a checkdeps.py "test". It doesn't have a success/fail for the time being, but it runs checkdeps.py with all the combination of packages present/absent on the system. It looks like prctl isn't checked correctly because it always complains about it, even if it is installed.