Skip to content

warn when frozen components break listener pattern#6766

Merged
honnibal merged 6 commits intoexplosion:developfrom
svlandeg:fix/tok2vec-disabled
Jan 20, 2021
Merged

warn when frozen components break listener pattern#6766
honnibal merged 6 commits intoexplosion:developfrom
svlandeg:fix/tok2vec-disabled

Conversation

@svlandeg
Copy link
Contributor

@svlandeg svlandeg commented Jan 19, 2021

Description

  • Change in Tok2Vec to store not only the listener Model instances, but also the downstream component names to which those listeners belong.
  • Warn when trying to train a component which has a frozen tok2vec layer, or when (re)training a tok2vec layer which has a downstream frozen component listening to it.
  • Added a few notes in the documentation

Types of change

UX enhancement

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

TODO

  • Update Transformer accordingly if we agree on this PR

@svlandeg svlandeg added feat / cli Feature: Command-line interface feat / config Feature: Training config feat / tok2vec Feature: Token-to-vector layer and pretraining feat / ux Feature: User experience, error messages etc. training Training and updating models 🌙 nightly Discussion and contributions related to nightly builds and removed feat / config Feature: Training config labels Jan 19, 2021
@honnibal
Copy link
Member

I think this'll definitely help! And yeah I agree that the name is the best thing to keep track of.

@honnibal honnibal merged commit 57640aa into explosion:develop Jan 20, 2021
@svlandeg svlandeg deleted the fix/tok2vec-disabled branch January 20, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat / cli Feature: Command-line interface feat / tok2vec Feature: Token-to-vector layer and pretraining feat / ux Feature: User experience, error messages etc. 🌙 nightly Discussion and contributions related to nightly builds training Training and updating models

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants