warn when frozen components break listener pattern#6766
Merged
honnibal merged 6 commits intoexplosion:developfrom Jan 20, 2021
Merged
warn when frozen components break listener pattern#6766honnibal merged 6 commits intoexplosion:developfrom
honnibal merged 6 commits intoexplosion:developfrom
Conversation
honnibal
reviewed
Jan 19, 2021
Member
|
I think this'll definitely help! And yeah I agree that the name is the best thing to keep track of. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tok2Vecto store not only the listenerModelinstances, but also the downstream component names to which those listeners belong.Types of change
UX enhancement
Checklist
TODO
Transformeraccordingly if we agree on this PR